starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-24 11:20:41 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #703] [MERGED] Improve egg import error handling #907

New Issue
Closed
opened 2026-02-04 19:01:03 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:01:03 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/703
Author: @Boy132
Created: 11/7/2024
Status: ✅ Merged
Merged: 11/8/2024
Merged by: @notAreYouScared

Base: main ← Head: improve/egg-import-error-handling

📝 Commits (2)

  • dc776c0 make sure read & write are successful
  • dc76e2d show exception message in notification

📊 Changes

2 files changed (+10 additions, -3 deletions)

View changed files

📝 app/Filament/Resources/EggResource/Pages/ListEggs.php (+2 -0)
📝 app/Services/Eggs/Sharing/EggImporterService.php (+8 -3)

📄 Description

  • Make sure file_put_contents was successful.
  • Throw InvalidFileUploadException instead of JsonException when json_decode fails.
  • Show exception message in notification.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/703 **Author:** [@Boy132](https://github.com/Boy132) **Created:** 11/7/2024 **Status:** ✅ Merged **Merged:** 11/8/2024 **Merged by:** [@notAreYouScared](https://github.com/notAreYouScared) **Base:** `main` ← **Head:** `improve/egg-import-error-handling` --- ### 📝 Commits (2) - [`dc776c0`](https://github.com/pelican-dev/panel/commit/dc776c082fd8dbf95ce18ba9a95967ab97604f98) make sure read & write are successful - [`dc76e2d`](https://github.com/pelican-dev/panel/commit/dc76e2d54b8e079aa4a07481f6074e8d5aebb6b5) show exception message in notification ### 📊 Changes **2 files changed** (+10 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Resources/EggResource/Pages/ListEggs.php` (+2 -0) 📝 `app/Services/Eggs/Sharing/EggImporterService.php` (+8 -3) </details> ### 📄 Description - Make sure `file_put_contents` was successful. - Throw `InvalidFileUploadException` instead of `JsonException` when `json_decode` fails. - Show exception message in notification. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:01:03 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#907
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?