starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-23 19:08:57 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #650] [MERGED] Installer: fix argument types for testConnection & return type for submit #877

New Issue
Closed
opened 2026-02-04 18:58:04 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 18:58:04 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/650
Author: @Boy132
Created: 10/21/2024
Status: ✅ Merged
Merged: 10/21/2024
Merged by: @Boy132

Base: main ← Head: fix/installer-param-type

📝 Commits (2)

  • af1f431 fix argument types for testConnection
  • c73c4a2 fix return type of submit

📊 Changes

3 files changed (+4 additions, -3 deletions)

View changed files

📝 app/Filament/Pages/Installer/PanelInstaller.php (+2 -1)
📝 app/Filament/Pages/Installer/Steps/DatabaseStep.php (+1 -1)
📝 app/Filament/Pages/Installer/Steps/RedisStep.php (+1 -1)

📄 Description

Fixes production.ERROR: App\Filament\Pages\Installer\Steps\DatabaseStep::testConnection(): Argument #2 ($host) must be of type string, null given when using sqlite.

Fixes production.ERROR: App\Filament\Pages\Installer\PanelInstaller::submit(): Return value must be of type Illuminate\Http\RedirectResponse, Livewire\Features\SupportRedirects\Redirector returned when clicking "Finish".

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/650 **Author:** [@Boy132](https://github.com/Boy132) **Created:** 10/21/2024 **Status:** ✅ Merged **Merged:** 10/21/2024 **Merged by:** [@Boy132](https://github.com/Boy132) **Base:** `main` ← **Head:** `fix/installer-param-type` --- ### 📝 Commits (2) - [`af1f431`](https://github.com/pelican-dev/panel/commit/af1f4310a3155c76fb0de25695c3eeedec2da9e7) fix argument types for `testConnection` - [`c73c4a2`](https://github.com/pelican-dev/panel/commit/c73c4a2212dd2dcc17a4c946aeff9c1f69fdcded) fix return type of submit ### 📊 Changes **3 files changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Pages/Installer/PanelInstaller.php` (+2 -1) 📝 `app/Filament/Pages/Installer/Steps/DatabaseStep.php` (+1 -1) 📝 `app/Filament/Pages/Installer/Steps/RedisStep.php` (+1 -1) </details> ### 📄 Description Fixes `production.ERROR: App\Filament\Pages\Installer\Steps\DatabaseStep::testConnection(): Argument #2 ($host) must be of type string, null given` when using sqlite. Fixes `production.ERROR: App\Filament\Pages\Installer\PanelInstaller::submit(): Return value must be of type Illuminate\Http\RedirectResponse, Livewire\Features\SupportRedirects\Redirector returned` when clicking "Finish". --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 18:58:04 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#877
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?