starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-24 11:20:41 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #532] [MERGED] Improve error handling for Installer #812

New Issue
Closed
opened 2026-02-04 18:52:39 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 18:52:39 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/532
Author: @Boy132
Created: 8/7/2024
Status: ✅ Merged
Merged: 8/9/2024
Merged by: @Boy132

Base: main ← Head: installer/error-reporting

📝 Commits (5)

  • a3170b2 make sure migrations ran
  • ebab86a add loading indicator to finish button
  • 867ed55 make error notification persistent
  • 066549e fix migration checker
  • 7389a47 cleanup traits

📊 Changes

14 files changed (+65 additions, -40 deletions)

View changed files

📝 app/Console/Commands/Environment/AppSettingsCommand.php (+1 -1)
📝 app/Console/Commands/Environment/CacheSettingsCommand.php (+2 -2)
📝 app/Console/Commands/Environment/DatabaseSettingsCommand.php (+1 -1)
📝 app/Console/Commands/Environment/EmailSettingsCommand.php (+1 -1)
📝 app/Console/Commands/Environment/QueueSettingsCommand.php (+2 -2)
📝 app/Console/Commands/Environment/SessionSettingsCommand.php (+2 -2)
📝 app/Console/Commands/Overrides/SeedCommand.php (+1 -1)
📝 app/Console/Commands/Overrides/UpCommand.php (+1 -1)
📝 app/Filament/Pages/Installer/PanelInstaller.php (+13 -2)
📝 app/Filament/Pages/Settings.php (+1 -1)
➕ app/Traits/CheckMigrationsTrait.php (+29 -0)
📝 app/Traits/Commands/RequiresDatabaseMigrations.php (+6 -22)
📝 app/Traits/EnvironmentWriterTrait.php (+4 -3)
📝 tests/Unit/Helpers/EnvironmentWriterTraitTest.php (+1 -1)

📄 Description

  • Added loading circle to "Finish" button.
  • Errors are now reported to the logs and the error notifaction is persistent.
  • Additional check to make sure all migrations have run.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/532 **Author:** [@Boy132](https://github.com/Boy132) **Created:** 8/7/2024 **Status:** ✅ Merged **Merged:** 8/9/2024 **Merged by:** [@Boy132](https://github.com/Boy132) **Base:** `main` ← **Head:** `installer/error-reporting` --- ### 📝 Commits (5) - [`a3170b2`](https://github.com/pelican-dev/panel/commit/a3170b27e98f1e9a482ceb65ad85408169d8ab6d) make sure migrations ran - [`ebab86a`](https://github.com/pelican-dev/panel/commit/ebab86a01ce47582f3e895a2cfc56f4b0ad48b9b) add loading indicator to finish button - [`867ed55`](https://github.com/pelican-dev/panel/commit/867ed55fd87a8d746658ea930f5b2c006753fd8c) make error notification persistent - [`066549e`](https://github.com/pelican-dev/panel/commit/066549e898f2e08878e2e7bf88aef582dcef2dd7) fix migration checker - [`7389a47`](https://github.com/pelican-dev/panel/commit/7389a4793671d55c46622f7a0a0721e65911602f) cleanup traits ### 📊 Changes **14 files changed** (+65 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `app/Console/Commands/Environment/AppSettingsCommand.php` (+1 -1) 📝 `app/Console/Commands/Environment/CacheSettingsCommand.php` (+2 -2) 📝 `app/Console/Commands/Environment/DatabaseSettingsCommand.php` (+1 -1) 📝 `app/Console/Commands/Environment/EmailSettingsCommand.php` (+1 -1) 📝 `app/Console/Commands/Environment/QueueSettingsCommand.php` (+2 -2) 📝 `app/Console/Commands/Environment/SessionSettingsCommand.php` (+2 -2) 📝 `app/Console/Commands/Overrides/SeedCommand.php` (+1 -1) 📝 `app/Console/Commands/Overrides/UpCommand.php` (+1 -1) 📝 `app/Filament/Pages/Installer/PanelInstaller.php` (+13 -2) 📝 `app/Filament/Pages/Settings.php` (+1 -1) ➕ `app/Traits/CheckMigrationsTrait.php` (+29 -0) 📝 `app/Traits/Commands/RequiresDatabaseMigrations.php` (+6 -22) 📝 `app/Traits/EnvironmentWriterTrait.php` (+4 -3) 📝 `tests/Unit/Helpers/EnvironmentWriterTraitTest.php` (+1 -1) </details> ### 📄 Description - Added loading circle to "Finish" button. - Errors are now reported to the logs and the error notifaction is persistent. - Additional check to make sure all migrations have run. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 18:52:39 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#812
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?