starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-25 03:14:39 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #485] [MERGED] Increase guzzle timeout when running tests #788

New Issue
Closed
opened 2026-02-04 18:50:43 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 18:50:43 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/485
Author: @Boy132
Created: 7/16/2024
Status: ✅ Merged
Merged: 7/20/2024
Merged by: @Boy132

Base: main ← Head: fix/tests-timeout

📝 Commits (2)

  • 87603c1 increase guzzle timeout when running tests
  • 84e28b7 catch correct exception

📊 Changes

2 files changed (+8 additions, -2 deletions)

View changed files

📝 .github/workflows/ci.yaml (+6 -0)
📝 app/Services/Helpers/SoftwareVersionService.php (+2 -2)

📄 Description

Some tests sporadically fail because the version check request times out. Increasing the timeouts during tests should prevent that.
Also changed the try catch exception from ClientException to GuzzleException.

grafik

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/485 **Author:** [@Boy132](https://github.com/Boy132) **Created:** 7/16/2024 **Status:** ✅ Merged **Merged:** 7/20/2024 **Merged by:** [@Boy132](https://github.com/Boy132) **Base:** `main` ← **Head:** `fix/tests-timeout` --- ### 📝 Commits (2) - [`87603c1`](https://github.com/pelican-dev/panel/commit/87603c174a579d16c879667f969202a4d949d9c5) increase guzzle timeout when running tests - [`84e28b7`](https://github.com/pelican-dev/panel/commit/84e28b7dbcb7db0db0475254bed7d95e947cc81d) catch correct exception ### 📊 Changes **2 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yaml` (+6 -0) 📝 `app/Services/Helpers/SoftwareVersionService.php` (+2 -2) </details> ### 📄 Description Some tests sporadically fail because the version check request times out. Increasing the timeouts during tests should prevent that. Also changed the try catch exception from `ClientException` to `GuzzleException`. ![grafik](https://github.com/user-attachments/assets/f9925b30-460f-4cdd-9ed7-56b7fc9b86df) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 18:50:43 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#788
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?