starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-25 03:14:39 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #411] [CLOSED] Add exception handling to CreateNode/ EditNode & CreateServer/ EditServer #743

New Issue
Closed
opened 2026-02-04 18:47:29 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 18:47:29 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/411
Author: @Boy132
Created: 6/17/2024
Status: ❌ Closed

Base: main ← Head: fix/handle-exceptions

📝 Commits (10+)

  • 26fad19 add exception handling to server & node
  • 7c0f46c turn FilamentExceptionHandler into trait
  • bb52e79 run pint
  • 5f64244 use trycatch instead of FilamentExceptionHandler
  • 4d18352 don't try to create allocations that already exist
  • d908b92 run pint
  • ed0c072 skip ports that are already created
  • 2684240 Merge branch 'pelican-dev:main' into fix/handle-exceptions
  • e0ef5cc Revert "skip ports that are already created"
  • c29c3f4 Revert "don't try to create allocations that already exist"

📊 Changes

6 files changed (+88 additions, -16 deletions)

View changed files

📝 app/Filament/Resources/NodeResource/Pages/CreateNode.php (+23 -1)
📝 app/Filament/Resources/NodeResource/Pages/EditNode.php (+20 -0)
📝 app/Filament/Resources/ServerResource/Pages/CreateServer.php (+20 -5)
📝 app/Filament/Resources/ServerResource/Pages/EditServer.php (+19 -0)
📝 app/Filament/Resources/UserResource/Pages/EditUser.php (+3 -6)
📝 app/Traits/Helpers/FilamentExceptionHandler.php (+3 -4)

📄 Description

We probably want to add some more fine tuned exception handling at some point but for now this stops all 500 errors or silent errors and replaces them with a notification.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/411 **Author:** [@Boy132](https://github.com/Boy132) **Created:** 6/17/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/handle-exceptions` --- ### 📝 Commits (10+) - [`26fad19`](https://github.com/pelican-dev/panel/commit/26fad19105becb8d1e4571313e85fc507da9d912) add exception handling to server & node - [`7c0f46c`](https://github.com/pelican-dev/panel/commit/7c0f46c7df0322075e5a67d2a07756e4a6732be0) turn FilamentExceptionHandler into trait - [`bb52e79`](https://github.com/pelican-dev/panel/commit/bb52e79b4ec79592a19166d9021200592ecea8a2) run pint - [`5f64244`](https://github.com/pelican-dev/panel/commit/5f642441a59ef895770f6bb291c9ebe2ad1ae09e) use trycatch instead of FilamentExceptionHandler - [`4d18352`](https://github.com/pelican-dev/panel/commit/4d183525d5f4667549bd49f58b12a2b482b14871) don't try to create allocations that already exist - [`d908b92`](https://github.com/pelican-dev/panel/commit/d908b92e75ff25b780e877414267d36c78f805fe) run pint - [`ed0c072`](https://github.com/pelican-dev/panel/commit/ed0c07233a217f6becb7cc4e8f96b3b84dc9a845) skip ports that are already created - [`2684240`](https://github.com/pelican-dev/panel/commit/2684240568c2c21584643a35fcd25159bafcd3fa) Merge branch 'pelican-dev:main' into fix/handle-exceptions - [`e0ef5cc`](https://github.com/pelican-dev/panel/commit/e0ef5cceb15e42bfc01f47821922f6127ec28d62) Revert "skip ports that are already created" - [`c29c3f4`](https://github.com/pelican-dev/panel/commit/c29c3f4d8dd7c885a41366c58ef8004a623e3733) Revert "don't try to create allocations that already exist" ### 📊 Changes **6 files changed** (+88 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Resources/NodeResource/Pages/CreateNode.php` (+23 -1) 📝 `app/Filament/Resources/NodeResource/Pages/EditNode.php` (+20 -0) 📝 `app/Filament/Resources/ServerResource/Pages/CreateServer.php` (+20 -5) 📝 `app/Filament/Resources/ServerResource/Pages/EditServer.php` (+19 -0) 📝 `app/Filament/Resources/UserResource/Pages/EditUser.php` (+3 -6) 📝 `app/Traits/Helpers/FilamentExceptionHandler.php` (+3 -4) </details> ### 📄 Description We probably want to add some more fine tuned exception handling at some point but for now this stops all 500 errors or silent errors and replaces them with a notification. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 18:47:29 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#743
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?