starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-24 11:20:41 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #358] [MERGED] Refactor egg services #709

New Issue
Closed
opened 2026-02-04 18:44:49 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 18:44:49 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/358
Author: @Boy132
Created: 6/10/2024
Status: ✅ Merged
Merged: 6/11/2024
Merged by: @Boy132

Base: main ← Head: refactor/egg-importer

📝 Commits (6)

  • 7ed1374 combine importer and updateimport
  • 25aad7e integrate egg parser into importer
  • 19ef054 remove EggCreationService and EggUpdateService
  • b1a88cf run pint
  • 73ed760 revert change to composer.json
  • e5f8d86 use egg exporter directly instead of old admin route

📊 Changes

10 files changed (+143 additions, -261 deletions)

View changed files

📝 app/Filament/Resources/EggResource/Pages/EditEgg.php (+2 -2)
📝 app/Http/Controllers/Admin/Eggs/EggController.php (+19 -6)
📝 app/Http/Controllers/Admin/Eggs/EggShareController.php (+1 -3)
➖ app/Services/Eggs/EggCreationService.php (+0 -29)
➖ app/Services/Eggs/EggParserService.php (+0 -108)
➖ app/Services/Eggs/EggUpdateService.php (+0 -26)
📝 app/Services/Eggs/Sharing/EggImporterService.php (+118 -12)
➖ app/Services/Eggs/Sharing/EggUpdateImporterService.php (+0 -67)
📝 composer.json (+1 -1)
📝 database/Seeders/EggSeeder.php (+2 -7)

📄 Description

  • Combined EggImporterService, EggUpdateImporterService and EggParserService into a single service
  • Removed EggCreationService & EggUpdateService
  • Replaced TODO uses old admin panel export service, now uses the export service directly instead of the old admin route

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/358 **Author:** [@Boy132](https://github.com/Boy132) **Created:** 6/10/2024 **Status:** ✅ Merged **Merged:** 6/11/2024 **Merged by:** [@Boy132](https://github.com/Boy132) **Base:** `main` ← **Head:** `refactor/egg-importer` --- ### 📝 Commits (6) - [`7ed1374`](https://github.com/pelican-dev/panel/commit/7ed1374c0d9019c1bbf7ad95702d65944fa35382) combine importer and updateimport - [`25aad7e`](https://github.com/pelican-dev/panel/commit/25aad7ee0b8cc929bb2d07a15da8f2a57ded8b1b) integrate egg parser into importer - [`19ef054`](https://github.com/pelican-dev/panel/commit/19ef054ed181d43d87154817dd0509eb1a90dc22) remove EggCreationService and EggUpdateService - [`b1a88cf`](https://github.com/pelican-dev/panel/commit/b1a88cfec9f1dd03f41d2d830232f97081706fe3) run pint - [`73ed760`](https://github.com/pelican-dev/panel/commit/73ed760900277c5bee1c2969c5c7b1981c0f64f3) revert change to composer.json - [`e5f8d86`](https://github.com/pelican-dev/panel/commit/e5f8d868f0cba9a92062215be4e4f11e31f264eb) use egg exporter directly instead of old admin route ### 📊 Changes **10 files changed** (+143 additions, -261 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Resources/EggResource/Pages/EditEgg.php` (+2 -2) 📝 `app/Http/Controllers/Admin/Eggs/EggController.php` (+19 -6) 📝 `app/Http/Controllers/Admin/Eggs/EggShareController.php` (+1 -3) ➖ `app/Services/Eggs/EggCreationService.php` (+0 -29) ➖ `app/Services/Eggs/EggParserService.php` (+0 -108) ➖ `app/Services/Eggs/EggUpdateService.php` (+0 -26) 📝 `app/Services/Eggs/Sharing/EggImporterService.php` (+118 -12) ➖ `app/Services/Eggs/Sharing/EggUpdateImporterService.php` (+0 -67) 📝 `composer.json` (+1 -1) 📝 `database/Seeders/EggSeeder.php` (+2 -7) </details> ### 📄 Description - Combined `EggImporterService`, `EggUpdateImporterService` and `EggParserService` into a single service - Removed `EggCreationService` & `EggUpdateService` - Replaced `TODO uses old admin panel export service`, now uses the export service directly instead of the old admin route --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 18:44:49 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#709
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?