starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-23 19:08:57 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #331] [MERGED] Fix the egg variable disaster... #692

New Issue
Closed
opened 2026-02-04 18:43:33 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 18:43:33 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/331
Author: @notAreYouScared
Created: 6/5/2024
Status: ✅ Merged
Merged: 6/7/2024
Merged by: @notAreYouScared

Base: main ← Head: charles/fixing-eggs

📝 Commits (9)

  • 7057c95 Migrations to update existing eggs in db
  • 3f6ed13 Update stock eggs
  • 8e6cf56 Update Eggs on import
  • 4aaed1a Also update updated versions of eggs that are uploaded
  • c5bd03a Redo this..
  • 2b359c2 Pint & Update replace
  • 77ad2a1 Squash Migrations, simplify logic
  • 9a04f52 Maybe this way...
  • c903ead Swap them over to single call

📊 Changes

10 files changed (+127 additions, -49 deletions)

View changed files

📝 app/Services/Eggs/EggConfigurationService.php (+1 -35)
📝 app/Services/Eggs/EggParserService.php (+20 -1)
📝 app/Services/Eggs/Sharing/EggImporterService.php (+1 -0)
📝 database/Seeders/eggs/minecraft/egg-bungeecord.json (+2 -2)
📝 database/Seeders/eggs/minecraft/egg-forge-minecraft.json (+2 -2)
📝 database/Seeders/eggs/minecraft/egg-paper.json (+2 -2)
📝 database/Seeders/eggs/minecraft/egg-sponge--sponge-vanilla.json (+3 -3)
📝 database/Seeders/eggs/minecraft/egg-vanilla-minecraft.json (+2 -2)
📝 database/Seeders/eggs/voice-servers/egg-mumble-server.json (+2 -2)
➕ database/migrations/2024_06_05_220135_update_egg_config_variables.php (+92 -0)

📄 Description

This PR does the following

Updates stock eggs, with new values for the config->file updates
Updates all eggs currently in the database, with migrations
As eggs are imported they're updated, then saved.

If we update them as they're saved, any time the egg is exported it should have the correct variables.

Closes https://github.com/pelican-dev/panel/issues/317

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/331 **Author:** [@notAreYouScared](https://github.com/notAreYouScared) **Created:** 6/5/2024 **Status:** ✅ Merged **Merged:** 6/7/2024 **Merged by:** [@notAreYouScared](https://github.com/notAreYouScared) **Base:** `main` ← **Head:** `charles/fixing-eggs` --- ### 📝 Commits (9) - [`7057c95`](https://github.com/pelican-dev/panel/commit/7057c95621f512790c233ddb809fb19ff047f3d7) Migrations to update existing eggs in db - [`3f6ed13`](https://github.com/pelican-dev/panel/commit/3f6ed137a3dd5eb787537b074659231b7606485b) Update stock eggs - [`8e6cf56`](https://github.com/pelican-dev/panel/commit/8e6cf56cbcb340b11fe227f67c446d5504d7620d) Update Eggs on import - [`4aaed1a`](https://github.com/pelican-dev/panel/commit/4aaed1a7c578b104eaa80d7ac7484e6fc3342473) Also update updated versions of eggs that are uploaded - [`c5bd03a`](https://github.com/pelican-dev/panel/commit/c5bd03a63e9c46c8f70cc7cfd30d9a7bc962ee6a) Redo this.. - [`2b359c2`](https://github.com/pelican-dev/panel/commit/2b359c2de21e73b517a24e5d6370b947941a5ca5) Pint & Update replace - [`77ad2a1`](https://github.com/pelican-dev/panel/commit/77ad2a14e4524e5e92b5d4e4eac297568008130e) Squash Migrations, simplify logic - [`9a04f52`](https://github.com/pelican-dev/panel/commit/9a04f5217f0b323fdd19ce487693159034e36e45) Maybe this way... - [`c903ead`](https://github.com/pelican-dev/panel/commit/c903ead64ec64ee7ed2de8d966c7552674abcb2c) Swap them over to single call ### 📊 Changes **10 files changed** (+127 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `app/Services/Eggs/EggConfigurationService.php` (+1 -35) 📝 `app/Services/Eggs/EggParserService.php` (+20 -1) 📝 `app/Services/Eggs/Sharing/EggImporterService.php` (+1 -0) 📝 `database/Seeders/eggs/minecraft/egg-bungeecord.json` (+2 -2) 📝 `database/Seeders/eggs/minecraft/egg-forge-minecraft.json` (+2 -2) 📝 `database/Seeders/eggs/minecraft/egg-paper.json` (+2 -2) 📝 `database/Seeders/eggs/minecraft/egg-sponge--sponge-vanilla.json` (+3 -3) 📝 `database/Seeders/eggs/minecraft/egg-vanilla-minecraft.json` (+2 -2) 📝 `database/Seeders/eggs/voice-servers/egg-mumble-server.json` (+2 -2) ➕ `database/migrations/2024_06_05_220135_update_egg_config_variables.php` (+92 -0) </details> ### 📄 Description This PR does the following Updates stock eggs, with new values for the config->file updates Updates all eggs currently in the database, with migrations As eggs are imported they're updated, then saved. If we update them as they're saved, any time the egg is exported it should have the correct variables. Closes https://github.com/pelican-dev/panel/issues/317 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 18:43:33 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#692
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?