starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-23 19:08:57 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #265] [MERGED] Simplify node deployment service, add filtering with tags instead of locations #665

New Issue
Closed
opened 2026-02-04 18:41:05 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 18:41:05 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/265
Author: @lancepioch
Created: 5/22/2024
Status: ✅ Merged
Merged: 5/25/2024
Merged by: @lancepioch

Base: main ← Head: issue/222

📝 Commits (9)

📊 Changes

12 files changed (+61 additions, -163 deletions)

View changed files

📝 .github/workflows/ci.yaml (+1 -1)
➖ app/Exceptions/Service/Deployment/NoViableNodeException.php (+0 -9)
📝 app/Http/Controllers/Admin/Servers/CreateServerController.php (+0 -1)
📝 app/Http/Controllers/Api/Application/Nodes/NodeDeploymentController.php (+7 -10)
📝 app/Http/Controllers/Api/Application/Servers/ServerController.php (+0 -1)
📝 app/Http/Requests/Api/Application/Nodes/GetDeployableNodesRequest.php (+4 -0)
📝 app/Http/Requests/Api/Application/Servers/StoreServerRequest.php (+10 -0)
📝 app/Models/Objects/DeploymentObject.php (+15 -0)
📝 app/Services/Deployment/AllocationSelectionService.php (+3 -5)
📝 app/Services/Deployment/FindViableNodesService.php (+14 -78)
📝 app/Services/Servers/ServerCreationService.php (+7 -8)
➖ tests/Integration/Services/Deployment/FindViableNodesServiceTest.php (+0 -50)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/265 **Author:** [@lancepioch](https://github.com/lancepioch) **Created:** 5/22/2024 **Status:** ✅ Merged **Merged:** 5/25/2024 **Merged by:** [@lancepioch](https://github.com/lancepioch) **Base:** `main` ← **Head:** `issue/222` --- ### 📝 Commits (9) - [`da698a3`](https://github.com/pelican-dev/panel/commit/da698a36666589847fb387ea222a18e8a20dfbbd) Remove exception - [`f9aa8cf`](https://github.com/pelican-dev/panel/commit/f9aa8cf2186dc10973e1352be6a9bceb0bd7befd) Simplify viable nodes service - [`5c33c74`](https://github.com/pelican-dev/panel/commit/5c33c7495a2af651917d2b8dc22010e96a2376a7) Ignore this for now - [`b579f14`](https://github.com/pelican-dev/panel/commit/b579f14f3f577d209abc2eb74dad4f23d2e8b25a) Backwards compatibility - [`b007e63`](https://github.com/pelican-dev/panel/commit/b007e63937645d9651f9eadcfa7830957ed8160f) Pint fixes - [`5146078`](https://github.com/pelican-dev/panel/commit/51460782cc487bdfcca6457be072e5eb7c635d4c) Merge branch 'main' into issue/222 - [`48f715a`](https://github.com/pelican-dev/panel/commit/48f715ae699dc30273c678988bb04002bab96052) Fix directory - [`5b9e4b1`](https://github.com/pelican-dev/panel/commit/5b9e4b172989709676762727025d4a0f99db36f1) Always limit by nodes, was like this before anyways - [`f4672c6`](https://github.com/pelican-dev/panel/commit/f4672c6cb1c4b5932a993a8106a6aba862a7c4df) Pint fix ### 📊 Changes **12 files changed** (+61 additions, -163 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yaml` (+1 -1) ➖ `app/Exceptions/Service/Deployment/NoViableNodeException.php` (+0 -9) 📝 `app/Http/Controllers/Admin/Servers/CreateServerController.php` (+0 -1) 📝 `app/Http/Controllers/Api/Application/Nodes/NodeDeploymentController.php` (+7 -10) 📝 `app/Http/Controllers/Api/Application/Servers/ServerController.php` (+0 -1) 📝 `app/Http/Requests/Api/Application/Nodes/GetDeployableNodesRequest.php` (+4 -0) 📝 `app/Http/Requests/Api/Application/Servers/StoreServerRequest.php` (+10 -0) 📝 `app/Models/Objects/DeploymentObject.php` (+15 -0) 📝 `app/Services/Deployment/AllocationSelectionService.php` (+3 -5) 📝 `app/Services/Deployment/FindViableNodesService.php` (+14 -78) 📝 `app/Services/Servers/ServerCreationService.php` (+7 -8) ➖ `tests/Integration/Services/Deployment/FindViableNodesServiceTest.php` (+0 -50) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 18:41:05 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#665
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?