starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-24 11:20:41 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #259] [CLOSED] Settings page & few small improvements #664

New Issue
Closed
opened 2026-02-04 18:41:05 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 18:41:05 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/259
Author: @Poseidon281
Created: 5/19/2024
Status: ❌ Closed

Base: main ← Head: Settings

📝 Commits (10+)

  • b896680 First Commit
  • 9e1410e Pint Fix
  • 04faf24 Delete useless helper
  • 0ec9d0b This should fix the config problem only it does not
  • 91a04c8 Merge remote-tracking branch 'upstream/main' into Settings
  • 1cd46b5 Added nav sort and Cache Flush
  • 2b7d013 Deleted unnecessary code
  • b989405 Merge remote-tracking branch 'upstream/main' into Settings
  • e61d3f3 Composer update
  • 1c3eaa0 Revert "Composer update"

📊 Changes

21 files changed (+271 additions, -841 deletions)

View changed files

📝 .env.example (+1 -1)
➖ app/Filament/Clusters/Settings.php (+0 -10)
➕ app/Filament/Resources/SettingResource.php (+61 -0)
➕ app/Filament/Resources/SettingResource/Pages/ManageSettings.php (+30 -0)
➖ app/Http/Controllers/Admin/Settings/AdvancedController.php (+0 -56)
➖ app/Http/Controllers/Admin/Settings/IndexController.php (+0 -56)
➖ app/Http/Controllers/Admin/Settings/MailController.php (+0 -82)
📝 app/Models/Setting.php (+113 -66)
📝 app/Providers/AppServiceProvider.php (+0 -5)
📝 app/Providers/Filament/AdminPanelProvider.php (+8 -0)
➖ app/Providers/SettingsServiceProvider.php (+0 -112)
📝 composer.json (+2 -1)
📝 composer.lock (+55 -1)
📝 config/panel.php (+0 -12)
📝 readme.md (+1 -1)
➖ resources/views/admin/settings/advanced.blade.php (+0 -127)
➖ resources/views/admin/settings/index.blade.php (+0 -75)
➖ resources/views/admin/settings/mail.blade.php (+0 -202)
📝 resources/views/layouts/admin.blade.php (+0 -5)
📝 resources/views/partials/admin/settings/notice.blade.php (+0 -9)

...and 1 more files

📄 Description

I made a settings page in the Filament admin side.

TODO List

✅ = Done
❔= Need help with/dont know how
❌ = Needs to be done/not yet started

Task Status Number
Only update settings when appy settings is pressed ✅ 1
Add descriptions to the settings ✅ 2
Add more settings Working on it 3
Apply Settings needs to be triggerd without the page expiring ❔/ No priority 4
Add tabs to the Settingspage ✅ 5
Add last updated column ✅ 7
Only trigger setConfigFromDatabase when Apply Settings is pressed and not on its own ✅ 8
Implement this Plugin for the settings Removed 9
Remove the database and make it a livewire page ✅ 10
Click anywhere it edits the settings ✅ 10
Make sure that the options and the limit works ✅ 11
Make that saving and appyling the settings works ✅ 12
Updating or removing the old API for the settings ❔/ No priority 13
Creating Import and Export Removed 14
Fix the saving bug ✅ 15
Removing the settings table in the DB and the SettingsServiceProvider Will be done later by Lance 16

Reminder 2: Talk to Lance about a paginated setting for the tables

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/259 **Author:** [@Poseidon281](https://github.com/Poseidon281) **Created:** 5/19/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `Settings` --- ### 📝 Commits (10+) - [`b896680`](https://github.com/pelican-dev/panel/commit/b896680e186306c66d8e02347ee70b1921855fc6) First Commit - [`9e1410e`](https://github.com/pelican-dev/panel/commit/9e1410e0f82ff9e2a549150bed19a2ac45dac34a) Pint Fix - [`04faf24`](https://github.com/pelican-dev/panel/commit/04faf248302e3f67ed14c831c4071fbd20bb6961) Delete useless helper - [`0ec9d0b`](https://github.com/pelican-dev/panel/commit/0ec9d0b2c94fd2392fda9af212522ac47c2a8208) This should fix the config problem only it does not - [`91a04c8`](https://github.com/pelican-dev/panel/commit/91a04c8afb603b16e77c95ea2a9198b301fd0d0b) Merge remote-tracking branch 'upstream/main' into Settings - [`1cd46b5`](https://github.com/pelican-dev/panel/commit/1cd46b5ad3957367576967d086da2fc838e026ea) Added nav sort and Cache Flush - [`2b7d013`](https://github.com/pelican-dev/panel/commit/2b7d013bd63597235faf162247612bebaa65b4b5) Deleted unnecessary code - [`b989405`](https://github.com/pelican-dev/panel/commit/b989405be8ea3dde837fba1f6e85e0eb42b49706) Merge remote-tracking branch 'upstream/main' into Settings - [`e61d3f3`](https://github.com/pelican-dev/panel/commit/e61d3f3c44313c5bc866d7e1fb0ddce541d7c3f3) Composer update - [`1c3eaa0`](https://github.com/pelican-dev/panel/commit/1c3eaa0254865f0434986d55637bc3bef93f2506) Revert "Composer update" ### 📊 Changes **21 files changed** (+271 additions, -841 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+1 -1) ➖ `app/Filament/Clusters/Settings.php` (+0 -10) ➕ `app/Filament/Resources/SettingResource.php` (+61 -0) ➕ `app/Filament/Resources/SettingResource/Pages/ManageSettings.php` (+30 -0) ➖ `app/Http/Controllers/Admin/Settings/AdvancedController.php` (+0 -56) ➖ `app/Http/Controllers/Admin/Settings/IndexController.php` (+0 -56) ➖ `app/Http/Controllers/Admin/Settings/MailController.php` (+0 -82) 📝 `app/Models/Setting.php` (+113 -66) 📝 `app/Providers/AppServiceProvider.php` (+0 -5) 📝 `app/Providers/Filament/AdminPanelProvider.php` (+8 -0) ➖ `app/Providers/SettingsServiceProvider.php` (+0 -112) 📝 `composer.json` (+2 -1) 📝 `composer.lock` (+55 -1) 📝 `config/panel.php` (+0 -12) 📝 `readme.md` (+1 -1) ➖ `resources/views/admin/settings/advanced.blade.php` (+0 -127) ➖ `resources/views/admin/settings/index.blade.php` (+0 -75) ➖ `resources/views/admin/settings/mail.blade.php` (+0 -202) 📝 `resources/views/layouts/admin.blade.php` (+0 -5) 📝 `resources/views/partials/admin/settings/notice.blade.php` (+0 -9) _...and 1 more files_ </details> ### 📄 Description I made a settings page in the Filament admin side. ### TODO List ✅ = Done ❔= Need help with/dont know how ❌ = Needs to be done/not yet started | Task | Status | Number | |--------|--------|--------| | Only update settings when appy settings is pressed | ✅ | 1 | | Add descriptions to the settings| ✅ | 2 | | Add more settings | Working on it | 3 | | Apply Settings needs to be triggerd without the page expiring | ❔/ No priority | 4 | | Add [tabs](https://filamentphp.com/docs/3.x/forms/layout/tabs) to the Settingspage | ✅ | 5 | | Add last updated column | ✅ | 7 | | Only trigger setConfigFromDatabase when Apply Settings is pressed and not on its own | ✅ | 8 | | Implement this [Plugin](https://filamentphp.com/plugins/tallyschmeits-character-counter) for the settings | Removed | 9 | Remove the database and make it a livewire page | ✅ | 10 | | Click anywhere it edits the settings | ✅ | 10 | | Make sure that the options and the limit works | ✅ | 11 | | Make that saving and appyling the settings works | ✅ | 12 | | Updating or removing the old API for the settings | ❔/ No priority | 13 | | Creating [Import](https://filamentphp.com/docs/3.x/actions/prebuilt-actions/import) and [Export](https://filamentphp.com/docs/3.x/actions/prebuilt-actions/export#automatically-generating-exporter-columns) | Removed | 14 | | Fix the saving bug |✅| 15 | | Removing the settings table in the DB and the SettingsServiceProvider | Will be done later by Lance | 16 | Reminder 2: Talk to Lance about a paginated setting for the tables --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 18:41:05 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#664
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?