starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-24 03:12:01 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

Unable to remove custom container labels which use dot notation (e.g. test.test) #312

New Issue
Closed
opened 2026-02-04 17:28:52 +03:00 by OVERLORD · 2 comments
OVERLORD commented 2026-02-04 17:28:52 +03:00
Owner
Copy Link

Originally created by @sebygreen on GitHub (Apr 14, 2025).

Originally assigned to: @rmartinoscar on GitHub.

Current Behavior

The panel throws an error when trying to delete custom container labels if they are formatted using dot notation. The error is thrown when saving the changes in the admin panel.

500 Server Error
Filament\Forms\Components\KeyValue::Filament\Forms\Components\{closure}(): Argument #1 ($value) must be of type ?string, array given

Expected Behavior

The container labels should be removed when saving, as they do when using a single word as a value.

Steps to Reproduce

  1. Navigate to Admin Panel → Servers → any_server → Environment Configuration → Docker Settings
  2. Insert a new label with name of test.test and any value
  3. Save the changes, should work fine
  4. Delete the previously created label test.test
  5. Save the changes, error is thrown here

This issue was first reported on discord, here
Relevant comment from mristau in the above thread:
"the docker labels are saved as a json object into database and it looks like it'll parse anything with "dot-notation" to an array. {data.docker_labels.test.test: "__rm__"} i suspect this here fails if there is dot-notation used inside a docker-label"

Panel Version

1.0.0-beta19

Wings Version

1.0.0-beta11

Games and/or Eggs Affected

Minecraft (Custom), Minecraft (Vanilla), Satisfactory

Docker Image

ghcr.io/parkervcp/yolks:java_21, ghcr.io/parkervcp/steamcmd:debian

Error Logs

Wings: https://paste.pelistuff.com/W4dR
Panel: https://paste.pelistuff.com/NmcT

Is there an existing issue for this?

  • I have searched the existing issues before opening this issue.
  • I have provided all relevant details, including the specific game and Docker images I am using if this issue is related to running a server.
  • I have checked in the Discord server and believe this is a bug with the software, and not a configuration issue with my specific system.
Originally created by @sebygreen on GitHub (Apr 14, 2025). Originally assigned to: @rmartinoscar on GitHub. ### Current Behavior The panel throws an error when trying to delete custom container labels if they are formatted using dot notation. The error is thrown when saving the changes in the admin panel. `500 Server Error` `Filament\Forms\Components\KeyValue::Filament\Forms\Components\{closure}(): Argument #1 ($value) must be of type ?string, array given` ### Expected Behavior The container labels should be removed when saving, as they do when using a single word as a value. ### Steps to Reproduce 1. Navigate to Admin Panel → Servers → any_server → Environment Configuration → Docker Settings 2. Insert a new label with name of `test.test` and any value 3. Save the changes, should work fine 4. Delete the previously created label `test.test` 5. Save the changes, error is thrown here This issue was first reported on discord, [here](https://discord.com/channels/1218730176297439332/1361283331467120803) Relevant comment from mristau in the above thread: "the docker labels are saved as a json object into database and it looks like it'll parse anything with "dot-notation" to an array. `{data.docker_labels.test.test: "__rm__"}` i suspect this here fails if there is dot-notation used inside a docker-label" ### Panel Version 1.0.0-beta19 ### Wings Version 1.0.0-beta11 ### Games and/or Eggs Affected Minecraft (Custom), Minecraft (Vanilla), Satisfactory ### Docker Image ghcr.io/parkervcp/yolks:java_21, ghcr.io/parkervcp/steamcmd:debian ### Error Logs ```bash Wings: https://paste.pelistuff.com/W4dR Panel: https://paste.pelistuff.com/NmcT ``` ### Is there an existing issue for this? - [x] I have searched the existing issues before opening this issue. - [x] I have provided all relevant details, including the specific game and Docker images I am using if this issue is related to running a server. - [x] I have checked in the Discord server and believe this is a bug with the software, and not a configuration issue with my specific system.
OVERLORD commented 2026-02-04 17:29:06 +03:00
Author
Owner
Copy Link

@rmartinoscar commented on GitHub (Apr 14, 2025):

https://docs.docker.com/engine/manage-resources/labels/#key-format-recommendations

Label keys should begin and end with a lower-case letter and should only contain lower-case alphanumeric characters, the period character (.), and the hyphen character (-). Consecutive periods or hyphens aren't allowed.

I will add a check so it doesn't crash but i can't see how did you manage to create a label with a dot in its labels

@rmartinoscar commented on GitHub (Apr 14, 2025): https://docs.docker.com/engine/manage-resources/labels/#key-format-recommendations >Label keys should begin and end with a lower-case letter and should only contain lower-case alphanumeric characters, the period character (.), and the hyphen character (-). Consecutive periods or hyphens aren't allowed. I will add a check so it doesn't crash but i can't see how did you manage to create a label with a dot in its labels
OVERLORD commented 2026-02-04 17:29:12 +03:00
Author
Owner
Copy Link

@sebygreen commented on GitHub (Apr 14, 2025):

it is my first time using labels. i was messing around with a server dashboard called glance. their system to render pretty docker container information uses labels such as glance.name or glance.icon.

many thanks for your time.

@sebygreen commented on GitHub (Apr 14, 2025): it is my first time using labels. i was messing around with a server dashboard called [glance](https://github.com/glanceapp/glance). their system to render pretty docker container information uses [labels](https://github.com/glanceapp/glance/blob/main/docs/configuration.md#docker-containers) such as `glance.name` or `glance.icon`. many thanks for your time.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#312
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?