starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-03-01 11:21:31 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

Wrong allocation limit #216

New Issue
Closed
opened 2026-02-04 17:07:39 +03:00 by OVERLORD · 4 comments
OVERLORD commented 2026-02-04 17:07:39 +03:00
Owner
Copy Link

Originally created by @Leon-JavaScript on GitHub (Dec 8, 2024).

Current Behavior

In the server settings tab in the client area, the Allocation Limit always shows 1 more than the actual limit.
image
image

Expected Behavior

It should show the correct allocation limit.

Steps to Reproduce

  1. Create a server with at least 1 on the allocation limit.
  2. Look at the settings tab in the client area
    It says you can create 1 more allocation than the limit.

Panel Version

Tested on 1.0.0-beta14 and canary (157fa45)

Wings Version

1.0.0-beta8

Games and/or Eggs Affected

No response

Docker Image

No response

Error Logs

No response

Is there an existing issue for this?

  • I have searched the existing issues before opening this issue.
  • I have provided all relevant details, including the specific game and Docker images I am using if this issue is related to running a server.
  • I have checked in the Discord server and believe this is a bug with the software, and not a configuration issue with my specific system.
Originally created by @Leon-JavaScript on GitHub (Dec 8, 2024). ### Current Behavior In the server settings tab in the client area, the `Allocation Limit` always shows 1 more than the actual limit. ![image](https://github.com/user-attachments/assets/62657d83-1b23-4e78-be5a-f15c2d4edcce) ![image](https://github.com/user-attachments/assets/c13740ad-bfac-4866-8ebc-6dcc8906d67d) ### Expected Behavior It should show the correct allocation limit. ### Steps to Reproduce 1. Create a server with at least 1 on the allocation limit. 2. Look at the settings tab in the client area *It says you can create 1 more allocation than the limit.* ### Panel Version Tested on 1.0.0-beta14 and canary (157fa45) ### Wings Version 1.0.0-beta8 ### Games and/or Eggs Affected _No response_ ### Docker Image _No response_ ### Error Logs _No response_ ### Is there an existing issue for this? - [X] I have searched the existing issues before opening this issue. - [X] I have provided all relevant details, including the specific game and Docker images I am using if this issue is related to running a server. - [X] I have checked in the Discord server and believe this is a bug with the software, and not a configuration issue with my specific system.
OVERLORD commented 2026-02-04 17:07:47 +03:00
Author
Owner
Copy Link

@Boy132 commented on GitHub (Dec 8, 2024):

That's intentional. The allocation limit is for additional allocations. And every server has at least 1 allocation.
So if you set the allocation limit to 3 you can actually have up to 4 allocations. (the default one + 3 additional) Wrong

@Boy132 commented on GitHub (Dec 8, 2024): ~~That's intentional. The allocation limit is for _additional_ allocations. And every server has at least 1 allocation. So if you set the allocation limit to 3 you can actually have up to 4 allocations. (the default one + 3 additional)~~ _Wrong_
OVERLORD commented 2026-02-04 17:07:51 +03:00
Author
Owner
Copy Link

@Leon-JavaScript commented on GitHub (Dec 8, 2024):

But in both client areas, it doesn't allow you to create the 1 allocation over the set amount in the settings.

@Leon-JavaScript commented on GitHub (Dec 8, 2024): But in both client areas, it doesn't allow you to create the 1 allocation over the set amount in the settings.
OVERLORD commented 2026-02-04 17:07:58 +03:00
Author
Owner
Copy Link

@rmartinoscar commented on GitHub (Dec 8, 2024):

8cc91b0747/config/panel.php (L92-L94)

Clients aren't allowed to create allocations by default you need to enable Automatic Allocation Creation
image

@rmartinoscar commented on GitHub (Dec 8, 2024): https://github.com/pelican-dev/panel/blob/8cc91b0747847ef30d1bc08bcf49b6f468bc8630/config/panel.php#L92-L94 Clients aren't allowed to create allocations by default you need to enable Automatic Allocation Creation ![image](https://github.com/user-attachments/assets/2b475c9c-7cf6-49fb-9d3f-2ee43dfce522)
OVERLORD commented 2026-02-04 17:08:01 +03:00
Author
Owner
Copy Link

@Leon-JavaScript commented on GitHub (Dec 8, 2024):

Even if you have the client allocation creation enabled, it doesn't allow you to set 3 allocations if you have set 2 in the settings of the server. I just tested it in the demo panel.

image
In the server settings (admin) I set the allocations to 2, in the settings information it shows 3.


image
In the network tab, it shows that the server reached the maximum allocations with 2 allocations.


So something must be wrong if I'm not completely mistaken. It must be one of these:
  1. The allocation create button respects the set limit from the set allocation limit in the server settings (admin). But with that, what Boy said, it should allow creating one more allocation.
  2. The display in the settings information is wrong and shows 1 too much, but Boy mentioned that's intentional, so I guess it's most likely the first one.
@Leon-JavaScript commented on GitHub (Dec 8, 2024): Even if you have the client allocation creation enabled, it doesn't allow you to set 3 allocations if you have set 2 in the settings of the server. I just tested it in the demo panel. ![image](https://github.com/user-attachments/assets/6fe259d1-5aaa-4cfb-8a9d-7a7322387697) In the server settings (admin) I set the allocations to 2, in the settings information it shows 3. <br> ![image](https://github.com/user-attachments/assets/e0252eb1-39d7-4c75-9eca-3b6c97f2e678) In the network tab, it shows that the server reached the maximum allocations with 2 allocations. <br> So something must be wrong if I'm not completely mistaken. It must be one of these: 1. The allocation create button respects the set limit from the set allocation limit in the server settings (admin). But with that, what Boy said, it should allow creating one more allocation. 2. The display in the settings information is wrong and shows 1 too much, but Boy mentioned that's intentional, so I guess it's most likely the first one.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#216
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?