starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-25 03:14:39 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #1934] [MERGED] Delete ssh keys shouldn't be a POST & Cleanup routes #1656

New Issue
Closed
opened 2026-02-04 20:05:24 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 20:05:24 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1934
Author: @rmartinoscar
Created: 11/26/2025
Status: ✅ Merged
Merged: 11/27/2025
Merged by: @rmartinoscar

Base: main ← Head: chore/routes

📝 Commits (2)

  • 162887f Delete ssh keys shouldn't be a POST & Cleanup routes
  • d98aff4 Proper refactor

📊 Changes

3 files changed (+23 additions, -32 deletions)

View changed files

📝 app/Http/Controllers/Api/Client/SSHKeyController.php (+9 -13)
📝 routes/api-client.php (+12 -10)
📝 tests/Integration/Api/Client/SSHKeyControllerTest.php (+2 -9)

📄 Description

BREAKING API CHANGE
POST client/account/ssh-keys/remove (fingerprint body) => DELETE client/account/ssh-keys/{fingerprint}

image image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1934 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 11/26/2025 **Status:** ✅ Merged **Merged:** 11/27/2025 **Merged by:** [@rmartinoscar](https://github.com/rmartinoscar) **Base:** `main` ← **Head:** `chore/routes` --- ### 📝 Commits (2) - [`162887f`](https://github.com/pelican-dev/panel/commit/162887f678442e9de5ac1a9ffa3d11a6a83ebad8) Delete ssh keys shouldn't be a POST & Cleanup routes - [`d98aff4`](https://github.com/pelican-dev/panel/commit/d98aff4c3fb26232e9821d28b95dc4b6c5b4c7d9) Proper refactor ### 📊 Changes **3 files changed** (+23 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/Api/Client/SSHKeyController.php` (+9 -13) 📝 `routes/api-client.php` (+12 -10) 📝 `tests/Integration/Api/Client/SSHKeyControllerTest.php` (+2 -9) </details> ### 📄 Description **BREAKING API CHANGE** POST client/account/ssh-keys/remove (fingerprint body) => DELETE client/account/ssh-keys/{fingerprint} <img width="292" height="263" alt="image" src="https://github.com/user-attachments/assets/712a398b-348f-4c85-976e-4d35b916ea10" /> <img width="292" height="263" alt="image" src="https://github.com/user-attachments/assets/9dc7ef90-c427-41db-bcbd-226277659e0b" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 20:05:24 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1656
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?