starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-25 03:14:39 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #1887] [MERGED] don't try to bulk update if egg doesn't even have a url #1638

New Issue
Closed
opened 2026-02-04 20:03:36 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 20:03:36 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1887
Author: @mristau
Created: 11/10/2025
Status: ✅ Merged
Merged: 11/13/2025
Merged by: @rmartinoscar

Base: main ← Head: UpdateEggBulk

📝 Commits (8)

  • 2e05adf don't try to bulk update if egg doesn't even have a url
  • 9a61d3f put the logic into the action and strict check
  • 873bd9e count skipped eggs too and display the number, coderabbit addition
  • 7e3048a adding back closing )
  • 9cf706b for you pint
  • 6a0b6b0 i forgot continue existed, hope it looks better now ;)
  • 86a4528 pint
  • 51382f5 maybe that new line

📊 Changes

2 files changed (+13 additions, -1 deletions)

View changed files

📝 app/Filament/Components/Actions/UpdateEggBulkAction.php (+12 -1)
📝 lang/en/admin/egg.php (+1 -0)

📄 Description

just checking if update_url is set, before doing bulk update
keeps it from spamming error messages from update_url=null

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1887 **Author:** [@mristau](https://github.com/mristau) **Created:** 11/10/2025 **Status:** ✅ Merged **Merged:** 11/13/2025 **Merged by:** [@rmartinoscar](https://github.com/rmartinoscar) **Base:** `main` ← **Head:** `UpdateEggBulk` --- ### 📝 Commits (8) - [`2e05adf`](https://github.com/pelican-dev/panel/commit/2e05adf7aebb9ca43fbbcfb4cd322ae136eb0da0) don't try to bulk update if egg doesn't even have a url - [`9a61d3f`](https://github.com/pelican-dev/panel/commit/9a61d3fe26444ab8645b519150078eb4ad2ff9d3) put the logic into the action and strict check - [`873bd9e`](https://github.com/pelican-dev/panel/commit/873bd9e58b0d87fb2bbdc6394de5705d1f2dc1a8) count skipped eggs too and display the number, coderabbit addition - [`7e3048a`](https://github.com/pelican-dev/panel/commit/7e3048a81fca3d98db9249292c914bddcb65228a) adding back closing ) - [`9cf706b`](https://github.com/pelican-dev/panel/commit/9cf706b8c26f34204ea3ea2bd867304d6572f278) for you pint - [`6a0b6b0`](https://github.com/pelican-dev/panel/commit/6a0b6b09d7d1fb7569b50fbf77ce591eea84d7ef) i forgot continue existed, hope it looks better now ;) - [`86a4528`](https://github.com/pelican-dev/panel/commit/86a452885febdb0b6855c0388004d4e069208635) pint - [`51382f5`](https://github.com/pelican-dev/panel/commit/51382f565cfc0335dd0b5e6df71caa0a9a0286ed) maybe that new line ### 📊 Changes **2 files changed** (+13 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Components/Actions/UpdateEggBulkAction.php` (+12 -1) 📝 `lang/en/admin/egg.php` (+1 -0) </details> ### 📄 Description just checking if update_url is set, before doing bulk update keeps it from spamming error messages from update_url=null <img width="415" height="694" alt="image" src="https://github.com/user-attachments/assets/ab8a5606-1081-4ba8-800d-44ad94447362" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 20:03:36 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1638
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?