starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-24 19:08:53 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #1799] [MERGED] Use tenantMiddleware instead of manually fetching tenant query param #1576

New Issue
Closed
opened 2026-02-04 19:58:34 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:58:34 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1799
Author: @rmartinoscar
Created: 10/12/2025
Status: ✅ Merged
Merged: 10/12/2025
Merged by: @rmartinoscar

Base: main ← Head: fix/serverTenancy

📝 Commits (1)

  • 085bf48 use tenantMiddleware instead of manually fetching tenant query parameter

📊 Changes

2 files changed (+3 additions, -5 deletions)

View changed files

📝 app/Http/Middleware/Activity/ServerSubject.php (+2 -4)
📝 app/Providers/Filament/ServerPanelProvider.php (+1 -1)

📄 Description

Closes #1786
Supersedes #1787

->middleware() runs prior to ->tenantMiddleware() so IdentifyTenant wasn't loaded and we couldn't use Filament::getTenant().

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1799 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 10/12/2025 **Status:** ✅ Merged **Merged:** 10/12/2025 **Merged by:** [@rmartinoscar](https://github.com/rmartinoscar) **Base:** `main` ← **Head:** `fix/serverTenancy` --- ### 📝 Commits (1) - [`085bf48`](https://github.com/pelican-dev/panel/commit/085bf48b1917b0f7e576260d534585a3b6790dda) use `tenantMiddleware` instead of manually fetching `tenant` query parameter ### 📊 Changes **2 files changed** (+3 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Middleware/Activity/ServerSubject.php` (+2 -4) 📝 `app/Providers/Filament/ServerPanelProvider.php` (+1 -1) </details> ### 📄 Description Closes #1786 Supersedes #1787 [`->middleware()`](https://github.com/filamentphp/filament/blob/4.x/packages/panels/routes/web.php#L26) runs prior to [`->tenantMiddleware()`](https://github.com/filamentphp/filament/blob/4.x/packages/panels/routes/web.php#L171) so [`IdentifyTenant`](https://github.com/filamentphp/filament/blob/4.x/packages/panels/src/Http/Middleware/IdentifyTenant.php#L38) wasn't loaded and we couldn't use `Filament::getTenant()`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:58:34 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1576
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?