starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-25 03:14:39 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #1715] [MERGED] Fix join_paths for absolute linux paths #1537

New Issue
Closed
opened 2026-02-04 19:55:08 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:55:08 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1715
Author: @Boy132
Created: 9/17/2025
Status: ✅ Merged
Merged: 9/17/2025
Merged by: @Boy132

Base: main ← Head: boy132/fix-join-paths

📝 Commits (1)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 app/helpers.php (+1 -1)

📄 Description

Only trim / at the end of the base to make sure absolute linux paths stay correct, e.g. join_paths(base_path(), 'test').

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1715 **Author:** [@Boy132](https://github.com/Boy132) **Created:** 9/17/2025 **Status:** ✅ Merged **Merged:** 9/17/2025 **Merged by:** [@Boy132](https://github.com/Boy132) **Base:** `main` ← **Head:** `boy132/fix-join-paths` --- ### 📝 Commits (1) - [`7f88560`](https://github.com/pelican-dev/panel/commit/7f885600f2da479e64e2c7822f536b68ef8df665) only trim base on right ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/helpers.php` (+1 -1) </details> ### 📄 Description Only trim `/` at the end of the base to make sure absolute linux paths stay correct, e.g. `join_paths(base_path(), 'test')`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:55:08 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1537
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?