starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-26 11:33:52 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #1703] [MERGED] Fix server owner permissions #1526

New Issue
Closed
opened 2026-02-04 19:54:18 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:54:18 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1703
Author: @danielkurek
Created: 9/12/2025
Status: ✅ Merged
Merged: 9/15/2025
Merged by: @lancepioch

Base: main ← Head: fix-owner-permissions

📝 Commits (2)

  • 99b343d Fix: server owner cannot update own server when he is also admin
  • 993cca9 fix lint issues

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 app/Services/Servers/GetUserPermissionsService.php (+4 -4)

📄 Description

I have stumbled upon a possible bug Server owner cannot start/restart/stop their own server if they have assigned some admin role without server update permission. I would expect that being a server owner would allow you to do anything with the server.

I am not sure if this is just a bug or if it is intentional. I have not read most of the codebase so I do not know if this change has some unwanted behaviour.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1703 **Author:** [@danielkurek](https://github.com/danielkurek) **Created:** 9/12/2025 **Status:** ✅ Merged **Merged:** 9/15/2025 **Merged by:** [@lancepioch](https://github.com/lancepioch) **Base:** `main` ← **Head:** `fix-owner-permissions` --- ### 📝 Commits (2) - [`99b343d`](https://github.com/pelican-dev/panel/commit/99b343dfa032d3ec090b487d7e73ad9819ef363d) Fix: server owner cannot update own server when he is also admin - [`993cca9`](https://github.com/pelican-dev/panel/commit/993cca9ae973a6322dd3128bd0dbe607c91a7777) fix lint issues ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `app/Services/Servers/GetUserPermissionsService.php` (+4 -4) </details> ### 📄 Description I have stumbled upon a possible bug Server owner cannot start/restart/stop their own server if they have assigned some admin role without server update permission. I would expect that being a server owner would allow you to do anything with the server. I am not sure if this is just a bug or if it is intentional. I have not read most of the codebase so I do not know if this change has some unwanted behaviour. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:54:18 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1526
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?