[PR #1668] [MERGED] Improve join_paths helper method #1517

Closed
opened 2026-02-04 19:53:28 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1668
Author: @Boy132
Created: 9/5/2025
Status: Merged
Merged: 9/8/2025
Merged by: @Boy132

Base: mainHead: boy132/fix-move-preview


📝 Commits (6)

📊 Changes

2 files changed (+14 additions, -8 deletions)

View changed files

📝 app/Filament/Server/Resources/FileResource/Pages/ListFiles.php (+6 -5)
📝 app/helpers.php (+8 -3)

📄 Description

Better handling for trailing / or empty paths.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1668 **Author:** [@Boy132](https://github.com/Boy132) **Created:** 9/5/2025 **Status:** ✅ Merged **Merged:** 9/8/2025 **Merged by:** [@Boy132](https://github.com/Boy132) **Base:** `main` ← **Head:** `boy132/fix-move-preview` --- ### 📝 Commits (6) - [`8c6490b`](https://github.com/pelican-dev/panel/commit/8c6490bc2c7159fea9a2a11b4239c19c905144c3) improve `join_paths` helper method - [`b6e9910`](https://github.com/pelican-dev/panel/commit/b6e991053d064a3be860d636f46568dfeb4c8406) trim first, then filter - [`5b36220`](https://github.com/pelican-dev/panel/commit/5b362208e155c702a2291b4d474250d36fddd861) also trim base - [`ed7fd70`](https://github.com/pelican-dev/panel/commit/ed7fd702c9eff6d9ee3895a692beba4ca54dfbd1) remove pointless `./` prefix - [`3fc4cda`](https://github.com/pelican-dev/panel/commit/3fc4cdaf2972a17714dd27a4586e4bb6a36f755e) small cleanup - [`7b8ee25`](https://github.com/pelican-dev/panel/commit/7b8ee258db2d49ea1216dff420576406b718acfc) fix activity log path ### 📊 Changes **2 files changed** (+14 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Server/Resources/FileResource/Pages/ListFiles.php` (+6 -5) 📝 `app/helpers.php` (+8 -3) </details> ### 📄 Description Better handling for trailing `/` or empty paths. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:53:28 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1517