starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-24 19:08:53 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #1626] [MERGED] fix: Wrong conversion if decimal prefix selected #1494

New Issue
Closed
opened 2026-02-04 19:51:34 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:51:34 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1626
Author: @SaurFort
Created: 8/20/2025
Status: ✅ Merged
Merged: 8/31/2025
Merged by: @Boy132

Base: main ← Head: fix-decimal-prefix

📝 Commits (2)

  • 41d21cd fix: Wrong conversion if decimal prefix selected
  • ec82b8b Change binary multiplier

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 app/Filament/Server/Widgets/ServerOverview.php (+1 -1)

📄 Description

When using the decimal prefix and setting 16 GB of RAM, the panel displayed 16.79 GB (without overhead) instead of 16 GB (without overhead).
This was due to the using of a binary multiplier (2^20), which is only correct for MiB/GiB.

So I've used the config('panel.use_binary_prefix') to check what multiplier should be used.

This is a visual fix, but I think it's better like that.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1626 **Author:** [@SaurFort](https://github.com/SaurFort) **Created:** 8/20/2025 **Status:** ✅ Merged **Merged:** 8/31/2025 **Merged by:** [@Boy132](https://github.com/Boy132) **Base:** `main` ← **Head:** `fix-decimal-prefix` --- ### 📝 Commits (2) - [`41d21cd`](https://github.com/pelican-dev/panel/commit/41d21cdc0a89b9b11467445874dceb0877b2ca95) fix: Wrong conversion if decimal prefix selected - [`ec82b8b`](https://github.com/pelican-dev/panel/commit/ec82b8b4c9b8a402739d710b3b80299aa2502259) Change binary multiplier ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Server/Widgets/ServerOverview.php` (+1 -1) </details> ### 📄 Description When using the decimal prefix and setting 16 GB of RAM, the panel displayed 16.79 GB (without overhead) instead of 16 GB (without overhead). This was due to the using of a binary multiplier (`2^20`), which is only correct for MiB/GiB. So I've used the `config('panel.use_binary_prefix')` to check what multiplier should be used. This is a visual fix, but I think it's better like that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:51:34 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1494
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?