starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-24 19:08:53 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #1559] [MERGED] remove maxlength rule from egg variable's default_value field #1451

New Issue
Closed
opened 2026-02-04 19:48:24 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:48:24 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1559
Author: @hasyirin
Created: 7/26/2025
Status: ✅ Merged
Merged: 8/1/2025
Merged by: @lancepioch

Base: main ← Head: fix/outdated-default_value-rule

📝 Commits (2)

  • a338b35 remove maxlength rule from default_value
  • bab2aae remove maxlength rule from default_value in Create page

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 app/Filament/Admin/Resources/EggResource/Pages/CreateEgg.php (+1 -1)
📝 app/Filament/Admin/Resources/EggResource/Pages/EditEgg.php (+1 -1)

📄 Description

The default_value field used to be string type in database, however it was changed to text.

Rust autowipe egg has a variable which has pretty lengthy default value, it will always throw an error whenever we try to edit the egg due to default_value being limited to 255.

Also since it's a text type in database, should the input for this field become textarea instead of normal text input?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1559 **Author:** [@hasyirin](https://github.com/hasyirin) **Created:** 7/26/2025 **Status:** ✅ Merged **Merged:** 8/1/2025 **Merged by:** [@lancepioch](https://github.com/lancepioch) **Base:** `main` ← **Head:** `fix/outdated-default_value-rule` --- ### 📝 Commits (2) - [`a338b35`](https://github.com/pelican-dev/panel/commit/a338b3509751c9aabd3069cda59bc768a38e6cc1) remove maxlength rule from default_value - [`bab2aae`](https://github.com/pelican-dev/panel/commit/bab2aaec2c69c247f2a35132546150fcc103379b) remove maxlength rule from default_value in Create page ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Admin/Resources/EggResource/Pages/CreateEgg.php` (+1 -1) 📝 `app/Filament/Admin/Resources/EggResource/Pages/EditEgg.php` (+1 -1) </details> ### 📄 Description The default_value field used to be string type in database, however it was changed to text. [Rust autowipe egg](https://github.com/pelican-eggs/games-steamcmd/blob/main/rust/rust_autowipe/egg-rust-autowipe.json) has a variable which has pretty lengthy default value, it will always throw an error whenever we try to edit the egg due to default_value being limited to 255. Also since it's a text type in database, should the input for this field become textarea instead of normal text input? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:48:24 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1451
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?