starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-03-01 11:21:31 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #1450] [MERGED] Fix some tests #1393

New Issue
Closed
opened 2026-02-04 19:42:52 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:42:52 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1450
Author: @pelican-vehikl
Created: 6/13/2025
Status: ✅ Merged
Merged: 6/19/2025
Merged by: @rmartinoscar

Base: main ← Head: fix-server-description-tests

📝 Commits (1)

📊 Changes

2 files changed (+6 additions, -4 deletions)

View changed files

📝 app/Http/Controllers/Api/Client/Servers/SettingsController.php (+4 -2)
📝 tests/Feature/SettingsControllerTest.php (+2 -2)

📄 Description

Fixes some tests that were failing.

One expected wrong status. Others were due to getOriginal() not working as expected.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1450 **Author:** [@pelican-vehikl](https://github.com/pelican-vehikl) **Created:** 6/13/2025 **Status:** ✅ Merged **Merged:** 6/19/2025 **Merged by:** [@rmartinoscar](https://github.com/rmartinoscar) **Base:** `main` ← **Head:** `fix-server-description-tests` --- ### 📝 Commits (1) - [`749e2a2`](https://github.com/pelican-dev/panel/commit/749e2a2f19d579cf51c9877cb8d3d97acc64d230) Fix some tests ### 📊 Changes **2 files changed** (+6 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/Api/Client/Servers/SettingsController.php` (+4 -2) 📝 `tests/Feature/SettingsControllerTest.php` (+2 -2) </details> ### 📄 Description Fixes some tests that were failing. One expected wrong status. Others were due to getOriginal() not working as expected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:42:52 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1393
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?