starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-24 11:20:41 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #1434] [MERGED] Fix error handling for deleting backups #1389

New Issue
Closed
opened 2026-02-04 19:42:28 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:42:28 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1434
Author: @Boy132
Created: 6/6/2025
Status: ✅ Merged
Merged: 6/7/2025
Merged by: @Boy132

Base: main ← Head: boy132/fix-deleting-nonexisting-backup

📝 Commits (3)

📊 Changes

3 files changed (+27 additions, -13 deletions)

View changed files

📝 app/Filament/Server/Resources/BackupResource.php (+22 -3)
📝 app/Services/Backups/DeleteBackupService.php (+3 -6)
📝 tests/Integration/Services/Backups/DeleteBackupServiceTest.php (+2 -4)

📄 Description

Correctly handle 404 errors from wings and handle node connection errors.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1434 **Author:** [@Boy132](https://github.com/Boy132) **Created:** 6/6/2025 **Status:** ✅ Merged **Merged:** 6/7/2025 **Merged by:** [@Boy132](https://github.com/Boy132) **Base:** `main` ← **Head:** `boy132/fix-deleting-nonexisting-backup` --- ### 📝 Commits (3) - [`2ec12ce`](https://github.com/pelican-dev/panel/commit/2ec12ce5c78f2d9bcc2c3c3b812392094654b0b8) fix error handling for deleting backups - [`99f9fa0`](https://github.com/pelican-dev/panel/commit/99f9fa0a833f22c24823d12e1aa60d0224b22984) fix tests - [`5acf7de`](https://github.com/pelican-dev/panel/commit/5acf7de3f28673680294fe69e50fa2197d7dcdd5) simplify exceptions ### 📊 Changes **3 files changed** (+27 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Server/Resources/BackupResource.php` (+22 -3) 📝 `app/Services/Backups/DeleteBackupService.php` (+3 -6) 📝 `tests/Integration/Services/Backups/DeleteBackupServiceTest.php` (+2 -4) </details> ### 📄 Description Correctly handle 404 errors from wings and handle node connection errors. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:42:28 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1389
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?