starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-24 19:08:53 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #1272] [MERGED] Fix develop Node Version reported as outdated #1294

New Issue
Closed
opened 2026-02-04 19:34:16 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:34:16 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1272
Author: @rmartinoscar
Created: 4/18/2025
Status: ✅ Merged
Merged: 4/18/2025
Merged by: @rmartinoscar

Base: main ← Head: fix/NodeVersionCheck

📝 Commits (1)

  • 74f6876 Fix develop Node Version reported as outdated

📊 Changes

1 file changed (+8 additions, -6 deletions)

View changed files

📝 app/Checks/NodeVersionsCheck.php (+8 -6)

📄 Description

If node version didn't match latestWingsVersion it was thought as outdated omitting the develop check so use the helper instead
038504fbec/app/Services/Helpers/SoftwareVersionService.php (L55-L62)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1272 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 4/18/2025 **Status:** ✅ Merged **Merged:** 4/18/2025 **Merged by:** [@rmartinoscar](https://github.com/rmartinoscar) **Base:** `main` ← **Head:** `fix/NodeVersionCheck` --- ### 📝 Commits (1) - [`74f6876`](https://github.com/pelican-dev/panel/commit/74f687639b692fab54ce2e1c2d26ee20c2dd5bdb) Fix `develop` Node Version reported as outdated ### 📊 Changes **1 file changed** (+8 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `app/Checks/NodeVersionsCheck.php` (+8 -6) </details> ### 📄 Description If node version didn't match latestWingsVersion it was thought as outdated omitting the `develop` check so use the helper instead https://github.com/pelican-dev/panel/blob/038504fbec3713ba4274b4310a746798dec3192c/app/Services/Helpers/SoftwareVersionService.php#L55-L62 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:34:16 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1294
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?