starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-24 19:08:53 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #1235] [MERGED] Fix serverVariables not saving due to join #1266

New Issue
Closed
opened 2026-02-04 19:31:45 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:31:45 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1235
Author: @rmartinoscar
Created: 4/11/2025
Status: ✅ Merged
Merged: 4/12/2025
Merged by: @rmartinoscar

Base: main ← Head: fix/ServerVariables

📝 Commits (2)

  • 7e00d40 Fix serverVariables not saving due to join
  • b3191d4 Remove deprecated viewableServerVariables

📊 Changes

5 files changed (+5 additions, -15 deletions)

View changed files

📝 app/Filament/Admin/Resources/ServerResource/Pages/CreateServer.php (+1 -1)
📝 app/Filament/Admin/Resources/ServerResource/Pages/EditServer.php (+1 -3)
📝 app/Filament/Server/Pages/Startup.php (+2 -1)
📝 app/Http/Controllers/Api/Client/Servers/StartupController.php (+1 -1)
📝 app/Models/Server.php (+0 -9)

📄 Description

https://github.com/user-attachments/assets/46cb994b-1d5c-4c32-8108-1f20488a9e1a

Bug introduced in #1172

Remove deprecated viewableServerVariables method on Server model

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1235 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 4/11/2025 **Status:** ✅ Merged **Merged:** 4/12/2025 **Merged by:** [@rmartinoscar](https://github.com/rmartinoscar) **Base:** `main` ← **Head:** `fix/ServerVariables` --- ### 📝 Commits (2) - [`7e00d40`](https://github.com/pelican-dev/panel/commit/7e00d40caa728a16c83c8a76ff189479999549de) Fix `serverVariables` not saving due to `join` - [`b3191d4`](https://github.com/pelican-dev/panel/commit/b3191d430754f51c0618fd34f2ffd1e4d3db3485) Remove deprecated `viewableServerVariables` ### 📊 Changes **5 files changed** (+5 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Admin/Resources/ServerResource/Pages/CreateServer.php` (+1 -1) 📝 `app/Filament/Admin/Resources/ServerResource/Pages/EditServer.php` (+1 -3) 📝 `app/Filament/Server/Pages/Startup.php` (+2 -1) 📝 `app/Http/Controllers/Api/Client/Servers/StartupController.php` (+1 -1) 📝 `app/Models/Server.php` (+0 -9) </details> ### 📄 Description https://github.com/user-attachments/assets/46cb994b-1d5c-4c32-8108-1f20488a9e1a Bug introduced in #1172 Remove deprecated `viewableServerVariables` method on `Server` model --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:31:45 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1266
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?