starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-24 11:20:41 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #1222] [MERGED] Update original migrations with nullable #1259

New Issue
Closed
opened 2026-02-04 19:30:58 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:30:58 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1222
Author: @lancepioch
Created: 4/6/2025
Status: ✅ Merged
Merged: 4/8/2025
Merged by: @lancepioch

Base: main ← Head: lance/migs

📝 Commits (1)

  • e01b738 These have to be nullable originally

📊 Changes

16 files changed (+18 additions, -18 deletions)

View changed files

📝 database/migrations/2016_08_30_213301_modify_ip_storage_method.php (+1 -1)
📝 database/migrations/2016_09_04_172028_update_failed_jobs_table.php (+1 -1)
📝 database/migrations/2016_09_07_163017_add_unique_identifier.php (+1 -1)
📝 database/migrations/2016_09_17_194246_add_docker_image_column.php (+1 -1)
📝 database/migrations/2016_10_14_164802_update_api_keys.php (+1 -1)
📝 database/migrations/2017_01_12_135449_add_more_user_data.php (+1 -1)
📝 database/migrations/2017_03_12_150648_MoveFunctionsFromFileToDatabase.php (+1 -1)
📝 database/migrations/2017_03_31_221948_AddServerDescriptionColumn.php (+1 -1)
📝 database/migrations/2017_10_02_202000_ChangeServicesToUseAMoreUniqueIdentifier.php (+1 -1)
📝 database/migrations/2017_10_02_202007_ChangeToABetterUniqueServiceConfiguration.php (+2 -2)
📝 database/migrations/2018_03_15_124536_add_description_to_nodes.php (+1 -1)
📝 database/migrations/2020_04_10_141024_store_node_tokens_as_encrypted_value.php (+2 -2)
📝 database/migrations/2021_01_10_153937_add_file_denylist_to_egg_configs.php (+1 -1)
📝 database/migrations/2021_01_13_013420_add_cron_month.php (+1 -1)
📝 database/migrations/2024_03_12_154408_remove_nests_table.php (+1 -1)
📝 database/migrations/2024_03_14_055537_remove_locations_table.php (+1 -1)

📄 Description

The recommended solution is to use migration squashing, but it's also safe to just explicitly declare these migration columns as nullable (as they were assumed to be beforehand anyways).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1222 **Author:** [@lancepioch](https://github.com/lancepioch) **Created:** 4/6/2025 **Status:** ✅ Merged **Merged:** 4/8/2025 **Merged by:** [@lancepioch](https://github.com/lancepioch) **Base:** `main` ← **Head:** `lance/migs` --- ### 📝 Commits (1) - [`e01b738`](https://github.com/pelican-dev/panel/commit/e01b7381863dc9a4314148e4160138814eaf53c1) These have to be nullable originally ### 📊 Changes **16 files changed** (+18 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `database/migrations/2016_08_30_213301_modify_ip_storage_method.php` (+1 -1) 📝 `database/migrations/2016_09_04_172028_update_failed_jobs_table.php` (+1 -1) 📝 `database/migrations/2016_09_07_163017_add_unique_identifier.php` (+1 -1) 📝 `database/migrations/2016_09_17_194246_add_docker_image_column.php` (+1 -1) 📝 `database/migrations/2016_10_14_164802_update_api_keys.php` (+1 -1) 📝 `database/migrations/2017_01_12_135449_add_more_user_data.php` (+1 -1) 📝 `database/migrations/2017_03_12_150648_MoveFunctionsFromFileToDatabase.php` (+1 -1) 📝 `database/migrations/2017_03_31_221948_AddServerDescriptionColumn.php` (+1 -1) 📝 `database/migrations/2017_10_02_202000_ChangeServicesToUseAMoreUniqueIdentifier.php` (+1 -1) 📝 `database/migrations/2017_10_02_202007_ChangeToABetterUniqueServiceConfiguration.php` (+2 -2) 📝 `database/migrations/2018_03_15_124536_add_description_to_nodes.php` (+1 -1) 📝 `database/migrations/2020_04_10_141024_store_node_tokens_as_encrypted_value.php` (+2 -2) 📝 `database/migrations/2021_01_10_153937_add_file_denylist_to_egg_configs.php` (+1 -1) 📝 `database/migrations/2021_01_13_013420_add_cron_month.php` (+1 -1) 📝 `database/migrations/2024_03_12_154408_remove_nests_table.php` (+1 -1) 📝 `database/migrations/2024_03_14_055537_remove_locations_table.php` (+1 -1) </details> ### 📄 Description The recommended solution is to use migration squashing, but it's also safe to just explicitly declare these migration columns as nullable (as they were assumed to be beforehand anyways). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:30:58 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1259
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?