starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-24 11:20:41 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #1135] [MERGED] Add FileNotEditableException #1198

New Issue
Closed
opened 2026-02-04 19:25:42 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:25:42 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1135
Author: @rmartinoscar
Created: 3/20/2025
Status: ✅ Merged
Merged: 4/3/2025
Merged by: @lancepioch

Base: main ← Head: fix/FileNotEditableException

📝 Commits (4)

  • 43b3df6 Add FileNotEditableException
  • e2df69f Send Notification instead of Throwing
  • 4a930d3 Remove useless function
  • f67ec1f Make them all AlertBanner

📊 Changes

4 files changed (+64 additions, -14 deletions)

View changed files

➕ app/Exceptions/Repository/FileNotEditableException.php (+7 -0)
📝 app/Filament/Server/Resources/FileResource/Pages/EditFiles.php (+44 -14)
📝 app/Repositories/Daemon/DaemonFileRepository.php (+5 -0)
➕ resources/views/errors/400.blade.php (+8 -0)

📄 Description

Catch trying to edit a Directory like if it was File content
https://github.com/pelican-dev/wings/pull/78
image
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1135 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 3/20/2025 **Status:** ✅ Merged **Merged:** 4/3/2025 **Merged by:** [@lancepioch](https://github.com/lancepioch) **Base:** `main` ← **Head:** `fix/FileNotEditableException` --- ### 📝 Commits (4) - [`43b3df6`](https://github.com/pelican-dev/panel/commit/43b3df639aca6110eda91031722629393b7a51f1) Add `FileNotEditableException` - [`e2df69f`](https://github.com/pelican-dev/panel/commit/e2df69f8f4a84c8a936f884977787d828e006824) Send `Notification` instead of Throwing - [`4a930d3`](https://github.com/pelican-dev/panel/commit/4a930d3dd8a2a15338793dc4e22277b98bbceaec) Remove useless `function` - [`f67ec1f`](https://github.com/pelican-dev/panel/commit/f67ec1f742a08c6d354cc324831ef490b811c73b) Make them all `AlertBanner` ### 📊 Changes **4 files changed** (+64 additions, -14 deletions) <details> <summary>View changed files</summary> ➕ `app/Exceptions/Repository/FileNotEditableException.php` (+7 -0) 📝 `app/Filament/Server/Resources/FileResource/Pages/EditFiles.php` (+44 -14) 📝 `app/Repositories/Daemon/DaemonFileRepository.php` (+5 -0) ➕ `resources/views/errors/400.blade.php` (+8 -0) </details> ### 📄 Description Catch trying to edit a `Directory` like if it was `File` content https://github.com/pelican-dev/wings/pull/78 ![image](https://github.com/user-attachments/assets/4024b29d-3870-4bff-bca3-e4c8d7c05003) ![image](https://github.com/user-attachments/assets/0cd66f0f-c61b-4b19-9d36-2d77e4372498) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:25:42 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1198
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?