starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-25 11:20:56 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #1106] [MERGED] Catch NodeUpdateService in EditNode & NodeController #1179

New Issue
Closed
opened 2026-02-04 19:24:16 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:24:16 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1106
Author: @rmartinoscar
Created: 3/16/2025
Status: ✅ Merged
Merged: 3/19/2025
Merged by: @rmartinoscar

Base: main ← Head: fix/CatchNodeUpdateService

📝 Commits (1)

  • d9c768f catch NodeUpdateService in EditNode & NodeController

📊 Changes

2 files changed (+22 additions, -6 deletions)

View changed files

📝 app/Filament/Admin/Resources/NodeResource/Pages/EditNode.php (+12 -1)
📝 app/Http/Controllers/Api/Application/Nodes/NodeController.php (+10 -5)

📄 Description

You get a 400 if trying to reset token when the wings is offline

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1106 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 3/16/2025 **Status:** ✅ Merged **Merged:** 3/19/2025 **Merged by:** [@rmartinoscar](https://github.com/rmartinoscar) **Base:** `main` ← **Head:** `fix/CatchNodeUpdateService` --- ### 📝 Commits (1) - [`d9c768f`](https://github.com/pelican-dev/panel/commit/d9c768f4d4059810e16b8f45fc72f7614abd2392) catch `NodeUpdateService` in `EditNode` & `NodeController` ### 📊 Changes **2 files changed** (+22 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Admin/Resources/NodeResource/Pages/EditNode.php` (+12 -1) 📝 `app/Http/Controllers/Api/Application/Nodes/NodeController.php` (+10 -5) </details> ### 📄 Description You get a 400 if trying to `reset token` when the wings is `offline` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:24:16 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1179
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?