starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-24 19:08:53 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #1081] [MERGED] Fix OAuth Routes, function calls need to be public #1168

New Issue
Closed
opened 2026-02-04 19:23:21 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:23:21 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1081
Author: @rmartinoscar
Created: 3/12/2025
Status: ✅ Merged
Merged: 3/12/2025
Merged by: @rmartinoscar

Base: main ← Head: fix/OauthRouteScope

📝 Commits (1)

  • 27675e6 Make redirect & callback public instead of private as required by Laravel 12

📊 Changes

2 files changed (+7 additions, -5 deletions)

View changed files

📝 app/Http/Controllers/Auth/OAuthController.php (+2 -2)
📝 routes/auth.php (+5 -3)

📄 Description

The scope now matters as of Laravel 12

[2025-03-09 18:07:28] production.ERROR: Call to protected method App\Http\Controllers\Auth\OAuthController::redirect() from scope Illuminate\Routing\ControllerDispatcher {"exception":"[object] (Error(code: 0): Call to protected method App\Http\Controllers\Auth\OAuthController::redirect() from scope Illuminate\Routing\ControllerDispatcher at /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php:47)
[stacktrace]

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1081 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 3/12/2025 **Status:** ✅ Merged **Merged:** 3/12/2025 **Merged by:** [@rmartinoscar](https://github.com/rmartinoscar) **Base:** `main` ← **Head:** `fix/OauthRouteScope` --- ### 📝 Commits (1) - [`27675e6`](https://github.com/pelican-dev/panel/commit/27675e6ac53fda0dc789d3ad636a730fdaef2edd) Make `redirect` & `callback` public instead of `private` as required by Laravel 12 ### 📊 Changes **2 files changed** (+7 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/Auth/OAuthController.php` (+2 -2) 📝 `routes/auth.php` (+5 -3) </details> ### 📄 Description The scope now matters as of Laravel 12 > [2025-03-09 18:07:28] production.ERROR: Call to protected method App\Http\Controllers\Auth\OAuthController::redirect() from scope Illuminate\Routing\ControllerDispatcher {"exception":"[object] (Error(code: 0): Call to protected method App\\Http\\Controllers\\Auth\\OAuthController::redirect() from scope Illuminate\\Routing\\ControllerDispatcher at /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php:47) [stacktrace] --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:23:21 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1168
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?