starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-24 19:08:53 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #1080] [MERGED] Fix FindViableNodeService to actually filter Tags #1162

New Issue
Closed
opened 2026-02-04 19:22:53 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:22:53 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1080
Author: @thibaultjunin
Created: 3/10/2025
Status: ✅ Merged
Merged: 3/13/2025
Merged by: @rmartinoscar

Base: main ← Head: patch-2

📝 Commits (4)

  • 4696157 fix viable node service to take into account tags
  • c358e9b Update app/Services/Deployment/FindViableNodesService.php
  • 732ffdd Update FindViableNodesService.php
  • 287184c Update FindViableNodesService.php

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 app/Services/Deployment/FindViableNodesService.php (+1 -1)

📄 Description

Hi,

I found out that tags (or locations_id) were ignored in the endpoint /nodes/deployable.

This PR fixes the issue by checking if the collection is not empty.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1080 **Author:** [@thibaultjunin](https://github.com/thibaultjunin) **Created:** 3/10/2025 **Status:** ✅ Merged **Merged:** 3/13/2025 **Merged by:** [@rmartinoscar](https://github.com/rmartinoscar) **Base:** `main` ← **Head:** `patch-2` --- ### 📝 Commits (4) - [`4696157`](https://github.com/pelican-dev/panel/commit/46961573c75791f584eaa2f104bd2a59b3248c67) fix viable node service to take into account tags - [`c358e9b`](https://github.com/pelican-dev/panel/commit/c358e9bfb6f49fb944fc02e826f0a45002c1d0d5) Update app/Services/Deployment/FindViableNodesService.php - [`732ffdd`](https://github.com/pelican-dev/panel/commit/732ffdd0525879d19dc0ce504c74e3a20680ee78) Update FindViableNodesService.php - [`287184c`](https://github.com/pelican-dev/panel/commit/287184c5e53502efec45dc5618f4211fa79ecdca) Update FindViableNodesService.php ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/Services/Deployment/FindViableNodesService.php` (+1 -1) </details> ### 📄 Description Hi, I found out that tags (or locations_id) were ignored in the endpoint `/nodes/deployable`. This PR fixes the issue by checking if the collection is not empty. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:22:53 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1162
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?