starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-03-01 11:21:31 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #1015] [MERGED] Don't log duplicated OauthProviders during tests #1118

New Issue
Closed
opened 2026-02-04 19:18:57 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:18:57 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1015
Author: @rmartinoscar
Created: 2/17/2025
Status: ✅ Merged
Merged: 2/24/2025
Merged by: @rmartinoscar

Base: main ← Head: fix/OauthProviderRegisteredMultipleTimes

📝 Commits (3)

  • a7e7467 Make sure OauthProviders are registered only once in AppServiceProvider
  • dd30398 Only log if not running tests
  • 5454dea Dependency inject

📊 Changes

7 files changed (+42 additions, -25 deletions)

View changed files

📝 app/Extensions/OAuth/Providers/AuthentikProvider.php (+5 -2)
📝 app/Extensions/OAuth/Providers/CommonProvider.php (+6 -4)
📝 app/Extensions/OAuth/Providers/DiscordProvider.php (+5 -2)
📝 app/Extensions/OAuth/Providers/GithubProvider.php (+5 -2)
📝 app/Extensions/OAuth/Providers/OAuthProvider.php (+5 -2)
📝 app/Extensions/OAuth/Providers/SteamProvider.php (+5 -2)
📝 app/Providers/AppServiceProvider.php (+11 -11)

📄 Description

image

5be4e22a0c/app/Extensions/OAuth/Providers/OAuthProvider.php (L22-L26)
I purposely left that in for future plugins

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1015 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 2/17/2025 **Status:** ✅ Merged **Merged:** 2/24/2025 **Merged by:** [@rmartinoscar](https://github.com/rmartinoscar) **Base:** `main` ← **Head:** `fix/OauthProviderRegisteredMultipleTimes` --- ### 📝 Commits (3) - [`a7e7467`](https://github.com/pelican-dev/panel/commit/a7e7467421e0bca7e3a378d330ded8b681e3f725) Make sure OauthProviders are registered only once in `AppServiceProvider` - [`dd30398`](https://github.com/pelican-dev/panel/commit/dd303984b94852bf9c4bcd78f4bb56382ca4c8d9) Only log if not running tests - [`5454dea`](https://github.com/pelican-dev/panel/commit/5454dea4037595cbb80a0f8c14f4459a0fb07653) Dependency inject ### 📊 Changes **7 files changed** (+42 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `app/Extensions/OAuth/Providers/AuthentikProvider.php` (+5 -2) 📝 `app/Extensions/OAuth/Providers/CommonProvider.php` (+6 -4) 📝 `app/Extensions/OAuth/Providers/DiscordProvider.php` (+5 -2) 📝 `app/Extensions/OAuth/Providers/GithubProvider.php` (+5 -2) 📝 `app/Extensions/OAuth/Providers/OAuthProvider.php` (+5 -2) 📝 `app/Extensions/OAuth/Providers/SteamProvider.php` (+5 -2) 📝 `app/Providers/AppServiceProvider.php` (+11 -11) </details> ### 📄 Description ![image](https://github.com/user-attachments/assets/bf625952-fa11-468e-bd87-aaa898499432) https://github.com/pelican-dev/panel/blob/5be4e22a0c932f11c5aba430942ae470bdd04970/app/Extensions/OAuth/Providers/OAuthProvider.php#L22-L26 I purposely left that in for future plugins --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:18:57 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1118
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?