starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-25 11:20:56 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #1018] [CLOSED] Validate eggVariable default_value using its rules #1116

New Issue
Closed
opened 2026-02-04 19:18:56 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:18:56 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1018
Author: @rmartinoscar
Created: 2/19/2025
Status: ❌ Closed

Base: main ← Head: fix/EggVariableDefaultValueRule

📝 Commits (2)

  • acdbc94 Validate eggVariable default_value using its rules
  • b65e11a Make the default_value field required

📊 Changes

2 files changed (+12 additions, -2 deletions)

View changed files

📝 app/Filament/Admin/Resources/EggResource/Pages/CreateEgg.php (+6 -1)
📝 app/Filament/Admin/Resources/EggResource/Pages/EditEgg.php (+6 -1)

📄 Description

image
image
image

I know about but i need it raw otherwise you have to save first.
324fc4b7d5/app/Models/EggVariable.php (L85-L88)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1018 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 2/19/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/EggVariableDefaultValueRule` --- ### 📝 Commits (2) - [`acdbc94`](https://github.com/pelican-dev/panel/commit/acdbc947261e310f7dfaf387dd316df79c3edb33) Validate eggVariable `default_value` using its `rules` - [`b65e11a`](https://github.com/pelican-dev/panel/commit/b65e11a5eb2e91cbbe0e3e6a929f54ee74887987) Make the `default_value` field required ### 📊 Changes **2 files changed** (+12 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Admin/Resources/EggResource/Pages/CreateEgg.php` (+6 -1) 📝 `app/Filament/Admin/Resources/EggResource/Pages/EditEgg.php` (+6 -1) </details> ### 📄 Description ![image](https://github.com/user-attachments/assets/475fbabb-51db-41a9-8912-8d7625e1298b) ![image](https://github.com/user-attachments/assets/756d0388-b72a-46c5-bc3d-6bdfe9e33010) ![image](https://github.com/user-attachments/assets/dfb3feb3-2f36-4ac9-8bb1-33745be847cb) I know about but i need it raw otherwise you have to save first. https://github.com/pelican-dev/panel/blob/324fc4b7d57d27e7b20ebcae9686af94ba2f0faa/app/Models/EggVariable.php#L85-L88 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:18:56 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1116
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?