starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-25 03:14:39 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #978] [CLOSED] Add isAdmin check to SelectableRecord in ListUsers #1094

New Issue
Closed
opened 2026-02-04 19:17:01 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:17:01 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/978
Author: @rmartinoscar
Created: 2/7/2025
Status: ❌ Closed

Base: main ← Head: fix/CanDeleteRootAdmin

📝 Commits (1)

  • 0f5e3f6 Add isAdmin check to SelectableRecord

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 app/Filament/Admin/Resources/UserResource/Pages/ListUsers.php (+1 -1)

📄 Description

No one should be able to delete any RootAdmin user from the panel.

Converted to Draft cause this Policy should already handle it
9ec2f6eae1/app/Models/User.php (L400-L407)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/978 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 2/7/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/CanDeleteRootAdmin` --- ### 📝 Commits (1) - [`0f5e3f6`](https://github.com/pelican-dev/panel/commit/0f5e3f6b3c6bfc25c2ad619abb04c922190f7abc) Add isAdmin check to SelectableRecord ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Admin/Resources/UserResource/Pages/ListUsers.php` (+1 -1) </details> ### 📄 Description No one should be able to delete any RootAdmin user from the panel. >Converted to Draft cause this Policy should already handle it https://github.com/pelican-dev/panel/blob/9ec2f6eae1a2764377d58dc610f49aa20ecbf711/app/Models/User.php#L400-L407 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:17:01 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1094
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?