starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-03-01 11:21:31 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #987] [MERGED] Fix revamp api_keys migration #1091

New Issue
Closed
opened 2026-02-04 19:16:57 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:16:57 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/987
Author: @rmartinoscar
Created: 2/10/2025
Status: ✅ Merged
Merged: 3/15/2025
Merged by: @lancepioch

Base: main ← Head: fix/RevampApiMigration

📝 Commits (2)

  • a8bc29f Fix revamp api_keys migration
  • c0b18f3 Merge branch 'main' into fix/RevampApiMigration

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 app/Models/ApiKey.php (+2 -2)
📝 database/migrations/2024_11_04_185326_revamp_api_keys_permissions.php (+2 -2)

📄 Description

Mysql only allow non-null default for json since ^8.0.13
And query should be all otherwise foreach runs even if there's no api_keys in the table.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/987 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 2/10/2025 **Status:** ✅ Merged **Merged:** 3/15/2025 **Merged by:** [@lancepioch](https://github.com/lancepioch) **Base:** `main` ← **Head:** `fix/RevampApiMigration` --- ### 📝 Commits (2) - [`a8bc29f`](https://github.com/pelican-dev/panel/commit/a8bc29f96f45d9c71593abba51b88c65c8d3c0c1) Fix revamp api_keys migration - [`c0b18f3`](https://github.com/pelican-dev/panel/commit/c0b18f3b37b71c9336e0f0d9a0b5325173c00d69) Merge branch 'main' into fix/RevampApiMigration ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `app/Models/ApiKey.php` (+2 -2) 📝 `database/migrations/2024_11_04_185326_revamp_api_keys_permissions.php` (+2 -2) </details> ### 📄 Description Mysql only allow non-null default for json since ^8.0.13 And query should be all otherwise foreach runs even if there's no api_keys in the table. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:16:57 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1091
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?