starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-24 11:20:41 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #898] [CLOSED] Make DynamicDatabaseConnection static #1044

New Issue
Closed
opened 2026-02-04 19:12:46 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:12:46 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/898
Author: @PseudoResonance
Created: 1/9/2025
Status: ❌ Closed

Base: main ← Head: static-dynamic-database-connection

📝 Commits (1)

  • c81a161 Make DynamicDatabaseConnection static

📊 Changes

5 files changed (+6 additions, -10 deletions)

View changed files

📝 app/Extensions/DynamicDatabaseConnection.php (+1 -1)
📝 app/Services/Databases/DatabaseManagementService.php (+2 -3)
📝 app/Services/Databases/DatabasePasswordService.php (+1 -2)
📝 app/Services/Databases/Hosts/HostCreationService.php (+1 -2)
📝 app/Services/Databases/Hosts/HostUpdateService.php (+1 -2)

📄 Description

I thought it was odd that this class, which has no internal state or anything, wasn't a static method and required instantiating the class first.
Does this seem reasonable to change, or is there some plan for it?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/898 **Author:** [@PseudoResonance](https://github.com/PseudoResonance) **Created:** 1/9/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `static-dynamic-database-connection` --- ### 📝 Commits (1) - [`c81a161`](https://github.com/pelican-dev/panel/commit/c81a161131f70b6b4943ddd4f77255429c06260e) Make DynamicDatabaseConnection static ### 📊 Changes **5 files changed** (+6 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `app/Extensions/DynamicDatabaseConnection.php` (+1 -1) 📝 `app/Services/Databases/DatabaseManagementService.php` (+2 -3) 📝 `app/Services/Databases/DatabasePasswordService.php` (+1 -2) 📝 `app/Services/Databases/Hosts/HostCreationService.php` (+1 -2) 📝 `app/Services/Databases/Hosts/HostUpdateService.php` (+1 -2) </details> ### 📄 Description I thought it was odd that this class, which has no internal state or anything, wasn't a static method and required instantiating the class first. Does this seem reasonable to change, or is there some plan for it? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:12:46 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1044
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?