starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-03-01 11:21:31 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #861] [MERGED] Fix 500 on duplicate ports #1020

New Issue
Closed
opened 2026-02-04 19:10:46 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:10:46 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/861
Author: @notAreYouScared
Created: 1/5/2025
Status: ✅ Merged
Merged: 1/5/2025
Merged by: @notAreYouScared

Base: main ← Head: charles/duplicate-ports

📝 Commits (10+)

📊 Changes

4 files changed (+141 additions, -176 deletions)

View changed files

📝 app/Filament/Admin/Resources/NodeResource/RelationManagers/AllocationsRelationManager.php (+8 -48)
📝 app/Filament/Admin/Resources/ServerResource/Pages/CreateServer.php (+125 -80)
📝 app/Filament/Admin/Resources/ServerResource/RelationManagers/AllocationsRelationManager.php (+6 -48)
📝 app/Models/Node.php (+2 -0)

📄 Description

This should also address N+1 issues from the last PR.

Also adds a 1000 port limit that's currently bypassed...

Old PR https://github.com/pelican-dev/panel/pull/661
Closes https://github.com/pelican-dev/panel/issues/655

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/861 **Author:** [@notAreYouScared](https://github.com/notAreYouScared) **Created:** 1/5/2025 **Status:** ✅ Merged **Merged:** 1/5/2025 **Merged by:** [@notAreYouScared](https://github.com/notAreYouScared) **Base:** `main` ← **Head:** `charles/duplicate-ports` --- ### 📝 Commits (10+) - [`37769df`](https://github.com/pelican-dev/panel/commit/37769dfc9ebb8f93ac530a46ab10feceb86a9e7b) Fix 500 on duplicate ports - [`0b3b77c`](https://github.com/pelican-dev/panel/commit/0b3b77cedcaa954bd6d44850f9cdda6e459a30b6) Combine into one method - [`7dfd712`](https://github.com/pelican-dev/panel/commit/7dfd71251f0fee87e890784be6f8ea94f2159250) Pint - [`1c05842`](https://github.com/pelican-dev/panel/commit/1c0584234c9b3065454175a7b502669d812d96ed) Add missing type - [`9e62fad`](https://github.com/pelican-dev/panel/commit/9e62fad7be91c5fcae42665ce0c8d99718624815) Add 0.0.0.0 - [`5ddf095`](https://github.com/pelican-dev/panel/commit/5ddf095d612c4420c682fede925e5e0f71f3eace) Add notifications to help the user - [`12459a2`](https://github.com/pelican-dev/panel/commit/12459a21fdb53dd0c647e8e462749678aecf9aea) Pint - [`a10fa3a`](https://github.com/pelican-dev/panel/commit/a10fa3a86eb0ee89c8843d847e51c9c931e78c83) Merge branch 'charles/duplicate-ports' of github.com:pelican-dev/panel into charles/duplicate-ports - [`034ab22`](https://github.com/pelican-dev/panel/commit/034ab22ba8de1891cc34e72340d0f1e21bd2409a) Too verbose - [`3c4886b`](https://github.com/pelican-dev/panel/commit/3c4886b003a200bdbb6b20489d4f6a29d292c36b) Show notification here ### 📊 Changes **4 files changed** (+141 additions, -176 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Admin/Resources/NodeResource/RelationManagers/AllocationsRelationManager.php` (+8 -48) 📝 `app/Filament/Admin/Resources/ServerResource/Pages/CreateServer.php` (+125 -80) 📝 `app/Filament/Admin/Resources/ServerResource/RelationManagers/AllocationsRelationManager.php` (+6 -48) 📝 `app/Models/Node.php` (+2 -0) </details> ### 📄 Description This should also address N+1 issues from the last PR. Also adds a 1000 port limit that's currently bypassed... Old PR https://github.com/pelican-dev/panel/pull/661 Closes https://github.com/pelican-dev/panel/issues/655 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:10:46 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#1020
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?