starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #722] [MERGED] Installer: Shows errors on submit & move runMigrations #924

New Issue
Closed
opened 2026-02-05 17:58:39 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 17:58:39 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/722
Author: @Boy132
Created: 11/21/2024
Status: ✅ Merged
Merged: 12/1/2024
Merged by: @Boy132

Base: main ← Head: fix/submit-errors

📝 Commits (3)

  • 8aaefc9 catch Halt exception to make sure error notifications are displayed
  • 69575d8 run migrations on submit to make sure the correct data is used
  • 2745260 Merge branch 'pelican-dev:main' into fix/submit-errors

📊 Changes

3 files changed (+18 additions, -19 deletions)

View changed files

📝 app/Filament/Pages/Installer/PanelInstaller.php (+17 -14)
📝 app/Filament/Pages/Installer/Steps/DatabaseStep.php (+0 -2)
📝 app/Filament/Pages/Installer/Steps/QueueStep.php (+1 -3)

📄 Description

Yet Another Installer PR.

Fixes errors on submit not showing because of Halt exception.
Moves the runMigrations call to submit to avoid cache problems.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/722 **Author:** [@Boy132](https://github.com/Boy132) **Created:** 11/21/2024 **Status:** ✅ Merged **Merged:** 12/1/2024 **Merged by:** [@Boy132](https://github.com/Boy132) **Base:** `main` ← **Head:** `fix/submit-errors` --- ### 📝 Commits (3) - [`8aaefc9`](https://github.com/pelican-dev/panel/commit/8aaefc91c3fb8dc44265d639171e1967060858dc) catch Halt exception to make sure error notifications are displayed - [`69575d8`](https://github.com/pelican-dev/panel/commit/69575d8184b5a9a77a0e4c290e0edb92ca916ed3) run migrations on submit to make sure the correct data is used - [`2745260`](https://github.com/pelican-dev/panel/commit/2745260ad46d9ff3db6fcd02e7d985f6483bebe8) Merge branch 'pelican-dev:main' into fix/submit-errors ### 📊 Changes **3 files changed** (+18 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Pages/Installer/PanelInstaller.php` (+17 -14) 📝 `app/Filament/Pages/Installer/Steps/DatabaseStep.php` (+0 -2) 📝 `app/Filament/Pages/Installer/Steps/QueueStep.php` (+1 -3) </details> ### 📄 Description _Yet Another Installer PR._ Fixes errors on submit not showing because of `Halt` exception. Moves the `runMigrations` call to submit to avoid cache problems. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 17:58:39 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#924
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?