starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #700] [MERGED] Fixing Docker Environment variable only getting checked for existence instead of value #911

New Issue
Closed
opened 2026-02-05 17:58:14 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 17:58:14 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/700
Author: @BlockyBlockling
Created: 11/4/2024
Status: ✅ Merged
Merged: 11/4/2024
Merged by: @parkervcp

Base: main ← Head: skip-caddy-fix

📝 Commits (3)

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 .github/docker/entrypoint.sh (+3 -3)

📄 Description

This is fixing possible misinterpretations of the provided docker compose file.
It was only checking for the existence of the environment variable „SKIP_CADDY“ instead of checking for its value.

Now it‘s making sure that the Environment variable is actually set to true so if a value like false is set, caddy will still be active.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/700 **Author:** [@BlockyBlockling](https://github.com/BlockyBlockling) **Created:** 11/4/2024 **Status:** ✅ Merged **Merged:** 11/4/2024 **Merged by:** [@parkervcp](https://github.com/parkervcp) **Base:** `main` ← **Head:** `skip-caddy-fix` --- ### 📝 Commits (3) - [`1a8321c`](https://github.com/pelican-dev/panel/commit/1a8321c93702bb0361855e6cde00f1dfdba02a75) Update entrypoint.sh - [`7514206`](https://github.com/pelican-dev/panel/commit/7514206186441391b6871beaa7cf560a2dead7ed) Update entrypoint.sh - [`968239b`](https://github.com/pelican-dev/panel/commit/968239beb365f71239d96e91830a5fd9cfa2fa46) Update entrypoint.sh ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/docker/entrypoint.sh` (+3 -3) </details> ### 📄 Description This is fixing possible misinterpretations of the provided docker compose file. It was only checking for the existence of the environment variable „SKIP_CADDY“ instead of checking for its value. Now it‘s making sure that the Environment variable is actually set to true so if a value like false is set, caddy will still be active. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 17:58:14 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#911
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?