starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #692] [MERGED] Fix trusted proxies settings & Move ips to config & Add ipv6 #904

New Issue
Closed
opened 2026-02-05 17:58:02 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 17:58:02 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/692
Author: @rmartinoscar
Created: 10/29/2024
Status: ✅ Merged
Merged: 11/2/2024
Merged by: @notAreYouScared

Base: main ← Head: fix/TrustedProxiesSettings

📝 Commits (4)

  • b893c92 Fix blank proxy & Move hardcoded cloudflare ips
  • d87a13b Add cloudflare's ipv6
  • f44eb21 Pull from url innstead of hardcoded
  • a627892 Remove Service

📊 Changes

1 file changed (+23 additions, -18 deletions)

View changed files

📝 app/Filament/Pages/Settings.php (+23 -18)

📄 Description

image
This was due to config('trustedproxy.proxies') being a string so you have to implode it otherwise it will put a blank string in by default
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/692 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 10/29/2024 **Status:** ✅ Merged **Merged:** 11/2/2024 **Merged by:** [@notAreYouScared](https://github.com/notAreYouScared) **Base:** `main` ← **Head:** `fix/TrustedProxiesSettings` --- ### 📝 Commits (4) - [`b893c92`](https://github.com/pelican-dev/panel/commit/b893c92c5cc90e897478179f3a674e8471b8fc84) Fix blank proxy & Move hardcoded cloudflare ips - [`d87a13b`](https://github.com/pelican-dev/panel/commit/d87a13b99e04de3cd502f19cccdbd57a89f7af79) Add cloudflare's ipv6 - [`f44eb21`](https://github.com/pelican-dev/panel/commit/f44eb219983dcdf78af1c9f02925c7f6945eeffe) Pull from url innstead of hardcoded - [`a627892`](https://github.com/pelican-dev/panel/commit/a627892c0bac6f673046c761d1a91c58adfa6c5b) Remove Service ### 📊 Changes **1 file changed** (+23 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Pages/Settings.php` (+23 -18) </details> ### 📄 Description ![image](https://github.com/user-attachments/assets/56603c31-4d5e-4a16-9937-fcd81628d46d) This was due to `config('trustedproxy.proxies')` being a string so you have to implode it otherwise it will put a blank string in by default ![image](https://github.com/user-attachments/assets/8273d49d-749d-451f-a8a8-7cb5957c69fb) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 17:58:02 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#904
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?