starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #677] [CLOSED] Allow path in Connection Address #893

New Issue
Closed
opened 2026-02-05 17:57:40 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 17:57:40 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/677
Author: @snipcola
Created: 10/27/2024
Status: ❌ Closed

Base: main ← Head: path-fqdn

📝 Commits (7)

  • a21d32f ability to include path in fqdn
  • cd90ba5 use laravel pint to format
  • 93a8452 don't override scheme
  • b04f488 add back parseFQDN
  • 38edc4b Merge branch 'pelican-dev:main' into path-fqdn
  • 5eb5785 use defined scheme instead of hardcoding
  • ebea566 run pint

📊 Changes

4 files changed (+39 additions, -13 deletions)

View changed files

📝 app/Filament/Resources/NodeResource/Pages/CreateNode.php (+4 -2)
📝 app/Filament/Resources/NodeResource/Pages/EditNode.php (+7 -4)
📝 app/Models/Node.php (+27 -6)
📝 app/Transformers/Api/Client/ServerTransformer.php (+1 -1)

📄 Description

Currently, if the connection address has a path, the port will end up after the path.
001150 Zen Browser 2024-10-27 16 41 06

001152 Zen Browser 2024-10-27 20 58 48

001154 Zen Browser 2024-10-27 20 59 50

This PR ensures the path comes after the port.
001146 Zen Browser 2024-10-27 16 39 58

001132 Zen Browser 2024-10-27 15 55 48

001156 Zen Browser 2024-10-27 21 00 18

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/677 **Author:** [@snipcola](https://github.com/snipcola) **Created:** 10/27/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `path-fqdn` --- ### 📝 Commits (7) - [`a21d32f`](https://github.com/pelican-dev/panel/commit/a21d32f1812e363fb15a6a8292a5f7f950c89cb7) ability to include path in fqdn - [`cd90ba5`](https://github.com/pelican-dev/panel/commit/cd90ba5731534c36b5e820b04adcb8948adb2215) use laravel pint to format - [`93a8452`](https://github.com/pelican-dev/panel/commit/93a84521918a035d597dc53e984365e57f4d8d79) don't override scheme - [`b04f488`](https://github.com/pelican-dev/panel/commit/b04f488711a672ebac2ff9a0d6302d6b976301ca) add back `parseFQDN` - [`38edc4b`](https://github.com/pelican-dev/panel/commit/38edc4bdf52180bc00a94f481ec3ec7521c0b5bf) Merge branch 'pelican-dev:main' into path-fqdn - [`5eb5785`](https://github.com/pelican-dev/panel/commit/5eb57856ecca51fef94a9c9e77ea95ff2bb81a28) use defined scheme instead of hardcoding - [`ebea566`](https://github.com/pelican-dev/panel/commit/ebea566ed81d43c3f3cf3a7718013adbf45214dd) run pint ### 📊 Changes **4 files changed** (+39 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Resources/NodeResource/Pages/CreateNode.php` (+4 -2) 📝 `app/Filament/Resources/NodeResource/Pages/EditNode.php` (+7 -4) 📝 `app/Models/Node.php` (+27 -6) 📝 `app/Transformers/Api/Client/ServerTransformer.php` (+1 -1) </details> ### 📄 Description Currently, if the connection address has a path, the port will end up after the path. ![001150 Zen Browser 2024-10-27 16 41 06](https://github.com/user-attachments/assets/0a54d467-20bb-456f-b985-71927afd619d) ![001152 Zen Browser 2024-10-27 20 58 48](https://github.com/user-attachments/assets/c115d5ac-5ea8-45e3-9b69-3e002c7c44b5) ![001154 Zen Browser 2024-10-27 20 59 50](https://github.com/user-attachments/assets/df8a7f1f-997d-44d5-b28c-c7c299aeea13) This PR ensures the path comes after the port. ![001146 Zen Browser 2024-10-27 16 39 58](https://github.com/user-attachments/assets/f026829f-29ad-4b43-ab1d-2edbd7288418) ![001132 Zen Browser 2024-10-27 15 55 48](https://github.com/user-attachments/assets/e7c30df2-2c90-4eb2-8136-83d75b786482) ![001156 Zen Browser 2024-10-27 21 00 18](https://github.com/user-attachments/assets/53be3d53-e3ee-4be2-bfac-335979c64032) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 17:57:40 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#893
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?