starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #610] [MERGED] Fix escaping for EnvironmentWriterTrait #856

New Issue
Closed
opened 2026-02-05 17:56:37 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 17:56:37 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/610
Author: @Boy132
Created: 10/7/2024
Status: ✅ Merged
Merged: 10/9/2024
Merged by: @Boy132

Base: main ← Head: fix/env-escaping

📝 Commits (3)

  • ab1f3fe fix escaping for EnvironmentWriterTrait
  • db9f9eb remove alphaNum from app name field
  • 6c6d643 add test for ' escaping

📊 Changes

3 files changed (+2 additions, -2 deletions)

View changed files

📝 app/Filament/Pages/Settings.php (+0 -1)
📝 app/Traits/EnvironmentWriterTrait.php (+1 -1)
📝 tests/Unit/Helpers/EnvironmentWriterTraitTest.php (+1 -0)

📄 Description

Properly fixes #562

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/610 **Author:** [@Boy132](https://github.com/Boy132) **Created:** 10/7/2024 **Status:** ✅ Merged **Merged:** 10/9/2024 **Merged by:** [@Boy132](https://github.com/Boy132) **Base:** `main` ← **Head:** `fix/env-escaping` --- ### 📝 Commits (3) - [`ab1f3fe`](https://github.com/pelican-dev/panel/commit/ab1f3fe3c5b73f3212d2d8f888699f1976fdf21c) fix escaping for EnvironmentWriterTrait - [`db9f9eb`](https://github.com/pelican-dev/panel/commit/db9f9eb9f227fdc030e3a1e671e400a28d52fac5) remove alphaNum from app name field - [`6c6d643`](https://github.com/pelican-dev/panel/commit/6c6d6430f2a9cf13465d5ab80f68b3449a0284ad) add test for `'` escaping ### 📊 Changes **3 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Pages/Settings.php` (+0 -1) 📝 `app/Traits/EnvironmentWriterTrait.php` (+1 -1) 📝 `tests/Unit/Helpers/EnvironmentWriterTraitTest.php` (+1 -0) </details> ### 📄 Description Properly fixes #562 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 17:56:37 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#856
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?