starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #529] [MERGED] Fix #524 Make default favicon path absolute to avoid 404 on admin #815

New Issue
Closed
opened 2026-02-05 17:55:26 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 17:55:26 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/529
Author: @rmartinoscar
Created: 8/6/2024
Status: ✅ Merged
Merged: 8/6/2024
Merged by: @notAreYouScared

Base: main ← Head: patch/favicon

📝 Commits (1)

  • 1396d36 Make default favicon path absolute to avoid 404 on admin

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 app/Filament/Pages/Settings.php (+1 -1)
📝 config/app.php (+1 -1)

📄 Description

Remove . to make the path absolute instead of relative
Just like everywhere else
2e094605e9/app/Providers/Filament/AdminPanelProvider.php (L41)
2e094605e9/resources/views/templates/wrapper.blade.php (L12)
2e094605e9/resources/views/layouts/admin.blade.php (L10)

why would you want an other icon specific to the admin side ?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/529 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 8/6/2024 **Status:** ✅ Merged **Merged:** 8/6/2024 **Merged by:** [@notAreYouScared](https://github.com/notAreYouScared) **Base:** `main` ← **Head:** `patch/favicon` --- ### 📝 Commits (1) - [`1396d36`](https://github.com/pelican-dev/panel/commit/1396d36d246797681c61debe3437ef2e1d84679b) Make default favicon path absolute to avoid 404 on admin ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Pages/Settings.php` (+1 -1) 📝 `config/app.php` (+1 -1) </details> ### 📄 Description Remove `.` to make the path absolute instead of relative Just like everywhere else https://github.com/pelican-dev/panel/blob/2e094605e9a300273fb97032c86b70703c06bb2d/app/Providers/Filament/AdminPanelProvider.php#L41 https://github.com/pelican-dev/panel/blob/2e094605e9a300273fb97032c86b70703c06bb2d/resources/views/templates/wrapper.blade.php#L12 https://github.com/pelican-dev/panel/blob/2e094605e9a300273fb97032c86b70703c06bb2d/resources/views/layouts/admin.blade.php#L10 >why would you want an other icon specific to the admin side ? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 17:55:26 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#815
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?