starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #466] [MERGED] Fix client Activity tab issues; fixes #465 #779

New Issue
Closed
opened 2026-02-05 17:54:10 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 17:54:10 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/466
Author: @ItzExotical
Created: 7/8/2024
Status: ✅ Merged
Merged: 7/10/2024
Merged by: @lancepioch

Base: main ← Head: main

📝 Commits (10+)

  • 2757370 Remove deploy.locations from validator
  • ab7f6fb Change location data to optional for backwards compat
  • b58df32 Better styling
  • 1806224 Add back comma to follow coding style
  • ebe39d8 Merge branch 'pelican-dev:main' into main
  • 7e7f237 Remove EventServiceProvider from providers file
  • 9276404 Add null check on $model->actor
  • eb3ca6f Proper type checking on $model->actor
  • f276195 Revert removal of EventServiceProvider
  • 6dc0070 Remove subscription of AuthenticationListener

📊 Changes

4 files changed (+1 additions, -14 deletions)

View changed files

📝 app/Listeners/Auth/AuthenticationListener.php (+0 -7)
📝 app/Providers/EventServiceProvider.php (+0 -5)
📝 app/Transformers/Api/Client/ActivityLogTransformer.php (+1 -1)
📝 bootstrap/providers.php (+0 -1)

📄 Description

This fixes both issues with the Activity tab, both duplicate entries as well as the page breaking after a failed auth attempt.
Tested and confirmed working on 2 different panel instances.

The second issue mentioned above was originally fixed by this commit by @lancepioch but was later overwritten (presumably by accident) on @DjordyKoert's commit here.

Huge thanks to @RMartinOscar for discovering why the log function was being called several times (because of entries in the providers file).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/466 **Author:** [@ItzExotical](https://github.com/ItzExotical) **Created:** 7/8/2024 **Status:** ✅ Merged **Merged:** 7/10/2024 **Merged by:** [@lancepioch](https://github.com/lancepioch) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (10+) - [`2757370`](https://github.com/pelican-dev/panel/commit/275737045e1c9bd484bfa3a2ae52b1f6f17b1fd1) Remove deploy.locations from validator - [`ab7f6fb`](https://github.com/pelican-dev/panel/commit/ab7f6fb8221a2e7166e0068fd1011231076d8a23) Change location data to optional for backwards compat - [`b58df32`](https://github.com/pelican-dev/panel/commit/b58df32b3db8cd30e68d04485f17c4998c497482) Better styling - [`1806224`](https://github.com/pelican-dev/panel/commit/18062247a8e87a14e16fb0ea8d7b27c5e9698432) Add back comma to follow coding style - [`ebe39d8`](https://github.com/pelican-dev/panel/commit/ebe39d8122eafc882bfc18bdce090efe31bf0c52) Merge branch 'pelican-dev:main' into main - [`7e7f237`](https://github.com/pelican-dev/panel/commit/7e7f237e371ff290f5e795b528e9b6d425db9de7) Remove EventServiceProvider from providers file - [`9276404`](https://github.com/pelican-dev/panel/commit/927640456497fe1760d93c96e66f19b030c2d5ca) Add null check on $model->actor - [`eb3ca6f`](https://github.com/pelican-dev/panel/commit/eb3ca6fd7a5ae002ce7c41417565525c4fda21d0) Proper type checking on $model->actor - [`f276195`](https://github.com/pelican-dev/panel/commit/f2761954db5ccf1fddaaa365d44fc1af32f2adaf) Revert removal of EventServiceProvider - [`6dc0070`](https://github.com/pelican-dev/panel/commit/6dc0070a0fb2cbd9d21aad60755ebc069c8e063c) Remove subscription of AuthenticationListener ### 📊 Changes **4 files changed** (+1 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `app/Listeners/Auth/AuthenticationListener.php` (+0 -7) 📝 `app/Providers/EventServiceProvider.php` (+0 -5) 📝 `app/Transformers/Api/Client/ActivityLogTransformer.php` (+1 -1) 📝 `bootstrap/providers.php` (+0 -1) </details> ### 📄 Description This fixes both issues with the Activity tab, both duplicate entries as well as the page breaking after a failed auth attempt. Tested and confirmed working on 2 different panel instances. The second issue mentioned above was originally fixed by [this](https://github.com/DjordyKoert/panel/commit/065f3f246803fbfa8517559f82c35d43cb426679) commit by @lancepioch but was later overwritten (presumably by accident) on @DjordyKoert's commit [here](https://github.com/pelican-dev/panel/pull/339/commits/4090c66af07442be3c5c37049a55972e3991f100#diff-e3f0808490450e9dd8161858e6d57f67e622bc1a1e32323c96be445dac96ad95R58). Huge thanks to @RMartinOscar for discovering why the log function was being called several times (because of entries in the providers file). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 17:54:10 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#779
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?