starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #455] [MERGED] Fixes #315 #770

New Issue
Closed
opened 2026-02-05 17:53:54 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 17:53:54 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/455
Author: @rmartinoscar
Created: 7/2/2024
Status: ✅ Merged
Merged: 7/2/2024
Merged by: @notAreYouScared

Base: main ← Head: patch-2

📝 Commits (1)

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 app/Filament/Resources/ServerResource/Pages/EditServer.php (+1 -2)

📄 Description

Remove check for databases linked to server before deletion as they get removed as well with ServerDeletionService
Here's notAreYouScared's commit actually fixing the issue on the backend
Fixing #315

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/455 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 7/2/2024 **Status:** ✅ Merged **Merged:** 7/2/2024 **Merged by:** [@notAreYouScared](https://github.com/notAreYouScared) **Base:** `main` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`4944090`](https://github.com/pelican-dev/panel/commit/4944090653920c50265e496549b031030ebd8969) Update EditServer.php ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Resources/ServerResource/Pages/EditServer.php` (+1 -2) </details> ### 📄 Description Remove check for databases linked to server before deletion as they get removed as well with [ServerDeletionService](https://github.com/pelican-dev/panel/blob/main/app/Services/Servers/ServerDeletionService.php#L64C55-L64C61) Here's notAreYouScared's [commit](https://github.com/pelican-dev/panel/commit/85b250d01614f075854e3d09ce85ccef2049e33d#diff-16cfe63641221821898b552395b81b98dac9e23e45265f4435c6bd0e3d4a2309R602) actually fixing the issue on the backend Fixing #315 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 17:53:54 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#770
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?