starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #423] [MERGED] Refactor UserTransformers #752

New Issue
Closed
opened 2026-02-05 17:53:26 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 17:53:26 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/423
Author: @Boy132
Created: 6/21/2024
Status: ✅ Merged
Merged: 6/23/2024
Merged by: @Boy132

Base: main ← Head: refactor/user-transformers

📝 Commits (6)

  • 1a0b887 remove AccountTransformer and update UserTransformer (client api) to match UserTransformer (application api)
  • 516f68f rename "toVueObject"
  • 273334a fix tests
  • 2fdd0ba forgot to rename this
  • d53efa5 backwards compat
  • 9d6c5c6 fix tests

📊 Changes

9 files changed (+33 additions, -51 deletions)

View changed files

📝 app/Http/Controllers/Api/Client/AccountController.php (+2 -2)
📝 app/Http/Controllers/Auth/AbstractLoginController.php (+1 -1)
📝 app/Models/User.php (+2 -2)
📝 app/Transformers/Api/Application/UserTransformer.php (+2 -1)
➖ app/Transformers/Api/Client/AccountTransformer.php (+0 -32)
📝 app/Transformers/Api/Client/UserTransformer.php (+13 -7)
📝 resources/views/templates/wrapper.blade.php (+1 -1)
📝 tests/Integration/Api/Application/Users/UserControllerTest.php (+4 -2)
📝 tests/Integration/Api/Client/AccountControllerTest.php (+8 -3)

📄 Description

Closes #419

Removes the unnecessary AccountTransformer and updates the client api UserTransformer to match the application api UserTransformer. Also renames toVueObject to toReactObject,

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/423 **Author:** [@Boy132](https://github.com/Boy132) **Created:** 6/21/2024 **Status:** ✅ Merged **Merged:** 6/23/2024 **Merged by:** [@Boy132](https://github.com/Boy132) **Base:** `main` ← **Head:** `refactor/user-transformers` --- ### 📝 Commits (6) - [`1a0b887`](https://github.com/pelican-dev/panel/commit/1a0b88761b7cb65c9d1eca5443f7167e6fe0eb2f) remove AccountTransformer and update UserTransformer (client api) to match UserTransformer (application api) - [`516f68f`](https://github.com/pelican-dev/panel/commit/516f68fc830a889dcf5793de125dc1106464f8c9) rename "toVueObject" - [`273334a`](https://github.com/pelican-dev/panel/commit/273334ac3dfb7a6ec0d45ce3fe57e510d5ba6e92) fix tests - [`2fdd0ba`](https://github.com/pelican-dev/panel/commit/2fdd0ba834a9ce02a785d4cd0d2bfd9518fb297e) forgot to rename this - [`d53efa5`](https://github.com/pelican-dev/panel/commit/d53efa5bc4586c25490c6619f745e6d8fd6394fe) backwards compat - [`9d6c5c6`](https://github.com/pelican-dev/panel/commit/9d6c5c69bbd25bf714d6dde12ac54ac20ea27647) fix tests ### 📊 Changes **9 files changed** (+33 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/Api/Client/AccountController.php` (+2 -2) 📝 `app/Http/Controllers/Auth/AbstractLoginController.php` (+1 -1) 📝 `app/Models/User.php` (+2 -2) 📝 `app/Transformers/Api/Application/UserTransformer.php` (+2 -1) ➖ `app/Transformers/Api/Client/AccountTransformer.php` (+0 -32) 📝 `app/Transformers/Api/Client/UserTransformer.php` (+13 -7) 📝 `resources/views/templates/wrapper.blade.php` (+1 -1) 📝 `tests/Integration/Api/Application/Users/UserControllerTest.php` (+4 -2) 📝 `tests/Integration/Api/Client/AccountControllerTest.php` (+8 -3) </details> ### 📄 Description Closes #419 Removes the unnecessary `AccountTransformer` and updates the client api `UserTransformer` to match the application api `UserTransformer`. Also renames `toVueObject` to `toReactObject`, --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 17:53:26 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#752
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?