starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #405] [MERGED] Remove locationId in MakeNodeCommand #739

New Issue
Closed
opened 2026-02-05 17:53:01 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 17:53:01 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/405
Author: @rmartinoscar
Created: 6/16/2024
Status: ✅ Merged
Merged: 6/17/2024
Merged by: @lancepioch

Base: main ← Head: patch-1

📝 Commits (3)

📊 Changes

5 files changed (+18 additions, -19 deletions)

View changed files

📝 app/Console/Commands/Node/MakeNodeCommand.php (+8 -8)
📝 app/Filament/Resources/NodeResource/Pages/CreateNode.php (+4 -4)
📝 app/Filament/Resources/NodeResource/Pages/EditNode.php (+4 -4)
📝 app/Models/Node.php (+1 -1)
📝 lang/en/commands.php (+1 -2)

📄 Description

Remove locationId as we don't use them anymore
Replace success1 & success2 with success and params
Set overallocate default as -1
Fix filament incorrect port range (1-65535 not 0-65536)
Enforce node_schema to only be either http or https

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/405 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 6/16/2024 **Status:** ✅ Merged **Merged:** 6/17/2024 **Merged by:** [@lancepioch](https://github.com/lancepioch) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (3) - [`af14bbc`](https://github.com/pelican-dev/panel/commit/af14bbc37bd5e1d0ca833478fbccac13d5c0f2ba) Concat + Default - [`9d43059`](https://github.com/pelican-dev/panel/commit/9d43059a2591210d0b59b741f2c497f1a9e9da3d) Concat + Default + Enforce scheme - [`d303265`](https://github.com/pelican-dev/panel/commit/d30326502f368d29e461bf09965036e723f61179) fix typo ### 📊 Changes **5 files changed** (+18 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `app/Console/Commands/Node/MakeNodeCommand.php` (+8 -8) 📝 `app/Filament/Resources/NodeResource/Pages/CreateNode.php` (+4 -4) 📝 `app/Filament/Resources/NodeResource/Pages/EditNode.php` (+4 -4) 📝 `app/Models/Node.php` (+1 -1) 📝 `lang/en/commands.php` (+1 -2) </details> ### 📄 Description Remove locationId as we don't use them anymore Replace success1 & success2 with success and params Set overallocate default as -1 Fix filament incorrect port range (1-65535 not 0-65536) Enforce node_schema to only be either http or https --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 17:53:01 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#739
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?