starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #326] [MERGED] Another call fix in AppSettingsCommand #693

New Issue
Closed
opened 2026-02-05 17:51:38 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 17:51:38 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/326
Author: @Boy132
Created: 6/4/2024
Status: ✅ Merged
Merged: 6/5/2024
Merged by: @lancepioch

Base: main ← Head: fix/artisan-queue-again

📝 Commits (4)

  • cff54f1 show output when running p:environment:queue-service
  • d81c9fa improve prompts
  • 0728266 restart queue service if service already exists
  • bb03ddd listen on all queues

📊 Changes

2 files changed (+25 additions, -13 deletions)

View changed files

📝 app/Console/Commands/Environment/AppSettingsCommand.php (+1 -1)
📝 app/Console/Commands/Environment/QueueWorkerServiceCommand.php (+24 -12)

📄 Description

Artisan::call doesn't actually display the output of the called command. Using $this->call fixes that.
I also added more context to the prompts in QueueWorkerServiceCommand.php to make the fields clearer and the service is now restarting automatically if it already exists.

This is the last fix regarding call I swear...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/326 **Author:** [@Boy132](https://github.com/Boy132) **Created:** 6/4/2024 **Status:** ✅ Merged **Merged:** 6/5/2024 **Merged by:** [@lancepioch](https://github.com/lancepioch) **Base:** `main` ← **Head:** `fix/artisan-queue-again` --- ### 📝 Commits (4) - [`cff54f1`](https://github.com/pelican-dev/panel/commit/cff54f1969f489edc0e69e3dd9d8f040320c8f67) show output when running `p:environment:queue-service` - [`d81c9fa`](https://github.com/pelican-dev/panel/commit/d81c9faac60a57c2548422bd9966c7d20b1a99aa) improve prompts - [`0728266`](https://github.com/pelican-dev/panel/commit/07282668264265f5478dd0916565fd3d659eeac4) restart queue service if service already exists - [`bb03ddd`](https://github.com/pelican-dev/panel/commit/bb03ddda5040f826cd3bcb6d4e863e27a7783645) listen on all queues ### 📊 Changes **2 files changed** (+25 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `app/Console/Commands/Environment/AppSettingsCommand.php` (+1 -1) 📝 `app/Console/Commands/Environment/QueueWorkerServiceCommand.php` (+24 -12) </details> ### 📄 Description `Artisan::call` doesn't actually display the output of the called command. Using `$this->call` fixes that. I also added more context to the prompts in `QueueWorkerServiceCommand.php` to make the fields clearer and the service is now restarting automatically if it already exists. _This is the last fix regarding `call` I swear..._ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 17:51:38 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#693
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?