starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #2129] [MERGED] Set failed plugin installs to "not_installed" instead of errored #1777

New Issue
Closed
opened 2026-02-05 18:24:25 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 18:24:25 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/2129
Author: @Boy132
Created: 1/21/2026
Status: ✅ Merged
Merged: 1/23/2026
Merged by: @Boy132

Base: main ← Head: boy132/installed-error-plugin-status

📝 Commits (2)

  • a34cd81 set failed installs to "not_installed" instead of errored
  • 264270b cleanup

📊 Changes

1 file changed (+32 additions, -38 deletions)

View changed files

📝 app/Services/Helpers/PluginService.php (+32 -38)

📄 Description

Followup for #2084

Failed installs should not be set to Errored because the plugin loader will try to load Errored plugins and if they load "successful" the plugin will be enabled again.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/2129 **Author:** [@Boy132](https://github.com/Boy132) **Created:** 1/21/2026 **Status:** ✅ Merged **Merged:** 1/23/2026 **Merged by:** [@Boy132](https://github.com/Boy132) **Base:** `main` ← **Head:** `boy132/installed-error-plugin-status` --- ### 📝 Commits (2) - [`a34cd81`](https://github.com/pelican-dev/panel/commit/a34cd81bd058971217d7431b6a7afdade564773a) set failed installs to "not_installed" instead of errored - [`264270b`](https://github.com/pelican-dev/panel/commit/264270b725f48b07c1d9c3c68f8eb7c55c4e2db8) cleanup ### 📊 Changes **1 file changed** (+32 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `app/Services/Helpers/PluginService.php` (+32 -38) </details> ### 📄 Description Followup for #2084 Failed installs should not be set to `Errored` because the plugin loader will try to load `Errored` plugins and if they load "successful" the plugin will be enabled again. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 18:24:25 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#1777
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?