starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-07-16 04:03:50 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #2085] [CLOSED] Fix broken download redirect #1750

New Issue
Closed
opened 2026-02-05 18:23:40 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 18:23:40 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/2085
Author: @hUwUtao
Created: 1/8/2026
Status: ❌ Closed

Base: main ← Head: patch/dwnld

📝 Commits (1)

  • ba57b1b Fix download redirect for file downloads

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 app/Filament/Server/Resources/Files/Pages/DownloadFiles.php (+3 -1)

📄 Description

The file download procedure do a single redirect to the download endpoint on wings. However, if redirect respond contains a body, it will not download for some reason.

HTTP Request when actual content is sent but not trigger browser download:

GET https://example.com/server/________/files/download/defaultconfigs/woodenbucket-server.toml HTTP/2.0
user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/130.0.0.0 Safari/537.36
accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
accept-encoding: gzip, deflate, br
accept-language: en-US,en;q=0.9

HTTP/2.0 302
date: Sun, 04 Jan 2026 09:09:31 GMT
content-type: text/html; charset=utf-8
location: https://example.com/download/file?token=________
cache-control: no-store
expires: Fri, 01 Jan 1990 00:00:00 GMT
pragma: no-cache
status: 302 Found

<!DOCTYPE html>
<html>
  <head>
    <meta charset="UTF-8" />
    <meta http-equiv="refresh" content="0;url='https://example.com/download/file?token=________'" />
    <title>Redirecting</title>
  </head>
  <body>
    Redirecting to <a href="https://example.com/download/file?token=________">download</a>.
  </body>
</html>

GET https://example.com/download/file?token=________ HTTP/2.0
user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/130.0.0.0 Safari/537.36
accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
accept-encoding: gzip, deflate, br
accept-language: en-US,en;q=0.9

HTTP/2.0 200
content-disposition: attachment; filename="woodenbucket-server.toml"
content-type: application/octet-stream
date: Sun, 04 Jan 2026 09:09:31 GMT
content-length: 770

["Balance Options"]
    crackingTemperature = 1000

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/2085 **Author:** [@hUwUtao](https://github.com/hUwUtao) **Created:** 1/8/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch/dwnld` --- ### 📝 Commits (1) - [`ba57b1b`](https://github.com/pelican-dev/panel/commit/ba57b1bb12efbef0a71e8ab18045d544a4541a88) Fix download redirect for file downloads ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Server/Resources/Files/Pages/DownloadFiles.php` (+3 -1) </details> ### 📄 Description The file download procedure do a single redirect to the download endpoint on wings. However, if redirect respond contains a body, it will not download for some reason. HTTP Request when actual content is sent but not trigger browser download: ``` GET https://example.com/server/________/files/download/defaultconfigs/woodenbucket-server.toml HTTP/2.0 user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/130.0.0.0 Safari/537.36 accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 accept-encoding: gzip, deflate, br accept-language: en-US,en;q=0.9 HTTP/2.0 302 date: Sun, 04 Jan 2026 09:09:31 GMT content-type: text/html; charset=utf-8 location: https://example.com/download/file?token=________ cache-control: no-store expires: Fri, 01 Jan 1990 00:00:00 GMT pragma: no-cache status: 302 Found <!DOCTYPE html> <html> <head> <meta charset="UTF-8" /> <meta http-equiv="refresh" content="0;url='https://example.com/download/file?token=________'" /> <title>Redirecting</title> </head> <body> Redirecting to <a href="https://example.com/download/file?token=________">download</a>. </body> </html> GET https://example.com/download/file?token=________ HTTP/2.0 user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/130.0.0.0 Safari/537.36 accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 accept-encoding: gzip, deflate, br accept-language: en-US,en;q=0.9 HTTP/2.0 200 content-disposition: attachment; filename="woodenbucket-server.toml" content-type: application/octet-stream date: Sun, 04 Jan 2026 09:09:31 GMT content-length: 770 ["Balance Options"] crackingTemperature = 1000 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 18:23:40 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#1750
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?