starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #2048] [MERGED] chore: Prevent users from caching Config #1731

New Issue
Closed
opened 2026-02-05 18:23:03 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 18:23:03 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/2048
Author: @rmartinoscar
Created: 12/24/2025
Status: ✅ Merged
Merged: 12/28/2025
Merged by: @rmartinoscar

Base: main ← Head: chore/disableConfigCache

📝 Commits (1)

  • faaa18c Prevent users from caching Config

📊 Changes

5 files changed (+39 additions, -3 deletions)

View changed files

➕ app/Console/Commands/Overrides/ConfigCacheCommand.php (+19 -0)
➕ app/Console/Commands/Overrides/OptimizeCommand.php (+18 -0)
📝 app/Filament/Admin/Pages/Settings.php (+0 -1)
📝 app/Livewire/Installer/PanelInstaller.php (+0 -2)
📝 app/Traits/EnvironmentWriterTrait.php (+2 -0)

📄 Description

Closes #2018
When config is cached every plugin config is null cause they use env(), I couldn't find anyway to circumvent this so i skipped config caching entirely.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/2048 **Author:** [@rmartinoscar](https://github.com/rmartinoscar) **Created:** 12/24/2025 **Status:** ✅ Merged **Merged:** 12/28/2025 **Merged by:** [@rmartinoscar](https://github.com/rmartinoscar) **Base:** `main` ← **Head:** `chore/disableConfigCache` --- ### 📝 Commits (1) - [`faaa18c`](https://github.com/pelican-dev/panel/commit/faaa18c74f47185389363fbb676b4f13eeb4c703) Prevent users from caching Config ### 📊 Changes **5 files changed** (+39 additions, -3 deletions) <details> <summary>View changed files</summary> ➕ `app/Console/Commands/Overrides/ConfigCacheCommand.php` (+19 -0) ➕ `app/Console/Commands/Overrides/OptimizeCommand.php` (+18 -0) 📝 `app/Filament/Admin/Pages/Settings.php` (+0 -1) 📝 `app/Livewire/Installer/PanelInstaller.php` (+0 -2) 📝 `app/Traits/EnvironmentWriterTrait.php` (+2 -0) </details> ### 📄 Description Closes #2018 When config is cached every plugin config is null cause they use `env()`, I couldn't find anyway to circumvent this so i skipped config caching entirely. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 18:23:03 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#1731
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?