mirror of
https://github.com/pelican-dev/panel.git
synced 2026-07-16 04:03:50 +03:00
Broken Web Installer #171
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rmartinoscar on GitHub (Oct 14, 2024).
Current Behavior
The last step is displayed before it should.
env_database.DB_DATABASEdefault will always bedatabase.sqliteeventhoughmariadborsqliteis selected.The installer still writes
DB_HOST,DB_PORT,DB_USERNAME,DB_PASSWORDeventhoughsqliteis selected.The page expires at the Admin step which forces you to refresh the page before processing.
Expected Behavior
Should only get displayed at the end.
We shouldn't
writeToEnv('env_general')before the redis step otherwise it won't work if the defaults don't match redis settings.It should create the admin user then go to the Setup complete step (without refresh) and Auto login.
Steps to Reproduce
Install as usual
Panel Version
latest (
c0eedc1)Wings Version
1.0.0-beta5 (not relevent)
Games and/or Eggs Affected
No response
Docker Image
No response
Error Logs
Is there an existing issue for this?
@rmartinoscar commented on GitHub (Oct 14, 2024):
Separating
env_general,env_databaseenv_rediswhen its all gonna get saved underenvkinda feels useless but i may be wrong.I also think that inputs should be kept otherwise you loose everything on page refresh (ToggleButtons & TextInput).
@Boy132 commented on GitHub (Oct 14, 2024):
That looks like a filament bug.
Yeah, you are right. It checks for the env variable instead of using
$get.That's because hidden fields are written too. But that's not a problem.
You didn't copy the .env.example file/ ran the setup command that copies it - or you changed the session driver.
That's intentional, the settings are written after each step rather than all together at the end.
@rmartinoscar commented on GitHub (Oct 14, 2024):
They shouldn't we just have to default to null and require(false) if the driver is
sqliteYou can't access the installer if you don't, i ran
php artisan p:environment:setupwhich copied .env.example into .env andkey:generatefor meStill if you save them before entering Redis credentials it will cause a 500 cause it can't connect to the cache, we have to save this at the redis step once the connection is successful.
@rmartinoscar commented on GitHub (Oct 14, 2024):
Still 500 on redis after #621 & #625 with the same error
@Boy132 commented on GitHub (Oct 14, 2024):
Post logs.
@rmartinoscar commented on GitHub (Oct 14, 2024):
Right after clicking
nextat the Database step before i can enter any redis credentials.Like i said exact same error as before
Im in General if you wanna talk this out
@Boy132 commented on GitHub (Oct 15, 2024):
That's because you changed the session driver to redis.
For the session driver we need to come up with something special anyways because that is the only setting that affects the installer directly. Even if we fix that 500 error we still have to deal with expiring sessions.
@rmartinoscar commented on GitHub (Oct 15, 2024):
I know which is why i moved
214eb5874f/app/Filament/Pages/Installer/Steps/EnvironmentStep.php (L96)under
214eb5874f/app/Filament/Pages/Installer/Steps/RedisStep.php (L55)I really don't know how can we defer this while keeping the separation between env writes
also made
function writeToEnv()return static so we can chain them like so