starred/panel-pelican-dev
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-05-04 18:00:48 +03:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #1939] [CLOSED] feat: add support for changing docker labels via application api #1665

New Issue
Closed
opened 2026-02-05 18:20:46 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 18:20:46 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/1939
Author: @m41denx
Created: 11/27/2025
Status: ❌ Closed

Base: main ← Head: feat/docker-tags-api

📝 Commits (9)

  • 2254c38 Docker labels
  • 12053f7 Rename $payload to $attributes
  • 13814b8 Ignore falsy docker_labels
  • 785124a Prevent docker labels from being a flat array and therefore having empty values
  • 3a401a5 Added docker labels validation
  • 70ae7e9 Validate Docker labels rule
  • a5350c2 Fix pint and phpstan errors
  • 321e9fe Update regex
  • 605b3e7 Return "required" validator

📊 Changes

7 files changed (+107 additions, -5 deletions)

View changed files

📝 app/Http/Requests/Api/Application/Servers/StoreServerRequest.php (+6 -0)
📝 app/Http/Requests/Api/Application/Servers/UpdateServerDetailsRequest.php (+10 -2)
📝 app/Models/Server.php (+2 -0)
➕ app/Rules/DockerLabel.php (+27 -0)
📝 app/Services/Servers/DetailsModificationService.php (+10 -3)
📝 app/Transformers/Api/Application/ServerTransformer.php (+1 -0)
📝 tests/Integration/Services/Servers/ServerCreationServiceTest.php (+51 -0)

📄 Description

This PR adds support for changing docker labels when creating server or modifying its details

Reasons for implementation:

  • Pelican already supports editing docker labels via filament
  • Support for container labels is one of Pelican's killer features that allows to use containers created by wings with sidecars (traefik, calico, node exporters and log collectors) so labels just have to have an API support

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/1939 **Author:** [@m41denx](https://github.com/m41denx) **Created:** 11/27/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/docker-tags-api` --- ### 📝 Commits (9) - [`2254c38`](https://github.com/pelican-dev/panel/commit/2254c3876b7407bccbcdd289aa94304a454c9692) Docker labels - [`12053f7`](https://github.com/pelican-dev/panel/commit/12053f7e16a0c51aa5f6344374fdef4a2845189e) Rename $payload to $attributes - [`13814b8`](https://github.com/pelican-dev/panel/commit/13814b8024c0e7e0d107b799079e9c9b4e2f4d76) Ignore falsy docker_labels - [`785124a`](https://github.com/pelican-dev/panel/commit/785124a765ecc15d23de7e183a1c46e4fb3412c8) Prevent docker labels from being a flat array and therefore having empty values - [`3a401a5`](https://github.com/pelican-dev/panel/commit/3a401a53ba361f21a5dfb7ede3c2cba220468155) Added docker labels validation - [`70ae7e9`](https://github.com/pelican-dev/panel/commit/70ae7e9cf0c76760ce2fb90a956ed89b12ae66f4) Validate Docker labels rule - [`a5350c2`](https://github.com/pelican-dev/panel/commit/a5350c2fc9f424159cadb1a80f81ec6ca3717cc0) Fix pint and phpstan errors - [`321e9fe`](https://github.com/pelican-dev/panel/commit/321e9fe687e74d6de9bd642fbcb651017c013278) Update regex - [`605b3e7`](https://github.com/pelican-dev/panel/commit/605b3e7b313e78e61c931570ee0a1667a7aad58d) Return "required" validator ### 📊 Changes **7 files changed** (+107 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Requests/Api/Application/Servers/StoreServerRequest.php` (+6 -0) 📝 `app/Http/Requests/Api/Application/Servers/UpdateServerDetailsRequest.php` (+10 -2) 📝 `app/Models/Server.php` (+2 -0) ➕ `app/Rules/DockerLabel.php` (+27 -0) 📝 `app/Services/Servers/DetailsModificationService.php` (+10 -3) 📝 `app/Transformers/Api/Application/ServerTransformer.php` (+1 -0) 📝 `tests/Integration/Services/Servers/ServerCreationServiceTest.php` (+51 -0) </details> ### 📄 Description This PR adds support for changing docker labels when creating server or modifying its details Reasons for implementation: - Pelican already supports editing docker labels via filament - Support for container labels is one of Pelican's killer features that allows to use containers created by wings with sidecars (traefik, calico, node exporters and log collectors) so labels just have to have an API support --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 18:20:46 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel-pelican-dev#1665
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?